Remove casting to user's custom type when passing data #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tishka17
reviewed
Apr 13, 2024
| @@ -120,7 +120,7 @@ async def _process_item_callback( | |||
| callback, | |||
| self.managed(manager), | |||
| manager, | |||
| self.type_factory(data), | |||
| data, | |||
There was a problem hiding this comment.
Looks like breaking normal select
arrenanv
commented
Apr 14, 2024
| @@ -181,7 +181,7 @@ async def _process_click( | |||
| await self.on_item_click.process_event( | |||
| callback, select, manager, self.type_factory(item_id), | |||
| ) | |||
| await self._on_click(callback, select, manager, str(item_id)) | |||
There was a problem hiding this comment.
So, would it be correct to return type casting in Select and remove it in StatefulSelect (line 182)? Also make a condition if item_id is the member of enum, then pass it as self.item_id_getter(item_id) instead of just casting to str.
|
Any updates? |
|
Currently not enough time, too much work on me. I will try to fix the issue on the next week maybe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is aimed to fix issue with doublecasting when sequence of enum members is passed as items of Select-like widgets