Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move fairness collector to the solver #428

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

chore: move fairness collector to the solver #428

wants to merge 1 commit into from

Conversation

triceo
Copy link
Contributor

@triceo triceo commented May 13, 2024

Description of the change

Description here

Checklist

Development

  • The changes have been covered with tests, if necessary.
  • You have a green build, with the exception of the flaky tests.
  • UI and JS files are fully tested, the user interface works for all modules affected by your changes (e.g., solve and analyze buttons).
  • The network calls work for all modules affected by your changes (e.g., solving a problem).
  • The console messages are validated for all modules affected by your changes.

Code Review

  • This pull request includes an explanatory title and description.
  • The GitHub issue is linked.
  • At least one other engineer has approved the changes.
  • After PR is merged, inform the reporter.

@triceo triceo changed the base branch from stable to development May 13, 2024 11:41
@triceo triceo requested a review from zepfred May 15, 2024 10:14
@triceo triceo marked this pull request as ready for review May 15, 2024 10:14
zepfred
zepfred approved these changes May 15, 2024
View reviewed changes
Copy link

@zepfred zepfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much simpler. Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zepfred zepfred zepfred approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@triceo @zepfred