Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): check peer dependencies in root package #101

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rafaelfbs
Copy link

Closes #88

The command manypkg check will check for dev or root dependencies when validating peerDependencies.

I had the same problem discussed in #88 when testing one package that depends on another package with react/react-dom deps. The test will fail saying that you have multiple versions of react.

@changeset-bot
Copy link

changeset-bot bot commented Jul 8, 2021

⚠️ No Changeset found

Latest commit: e5d47d6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant