Updated insertMulti #775
Open
Updated insertMulti #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Complete with fix for k warning.
avbdr
reviewed
Jul 19, 2018
MysqliDb.php
Outdated
| @@ -780,6 +780,13 @@ public function insertMulti($tableName, array $multiInsertData, array $dataKeys | |||
| $autoCommit = (isset($this->_transaction_in_progress) ? !$this->_transaction_in_progress : true); | |||
| $ids = array(); | |||
|
|
|||
| $options = [ | |||
There was a problem hiding this comment.
Please use old Array() syntax since we still support old php version
MysqliDb.php
Outdated
| return $ids; | ||
| } | ||
|
|
||
There was a problem hiding this comment.
please remove all whitespace changes
White spaces removed too ?
avbdr
reviewed
Jul 19, 2018
MysqliDb.php
Outdated
| $this->rollback(); | ||
| } | ||
| return false; | ||
| $id = false; |
There was a problem hiding this comment.
this still should be return false; plus previous comments are not addressed
|
I've changed the return type back to suit - I can't tell whats wrong with spacing per previous comment ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete with fix for k warning.