Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update type_checking_with_proptypes.md #27986

Closed
wants to merge 1 commit into from

Conversation

Dillonpw
Copy link
Contributor

Because

After discussing pros and cons in the issue, consensus was to offer these two links as resources to explore TypeScript, while not necessarily encouraging its use.

This PR

Issue

Closes #27249

Additional Information

Pull Request Requirements

  • [x ] I have thoroughly read and understand The Odin Project curriculum contributing guide
  • [ ]x The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • [ x] The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • [ x] If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: React Involves the React course label May 16, 2024
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Dillonpw. I believe the end consensus was instead to just remove the first Typescript link from line 82 and that's it (i.e. don't create any additional resource links).

@Dillonpw Dillonpw closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: React Involves the React course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<React>: <Type Checking with Prop Types additional resources>
2 participants