-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update from legacy doc #27972
Update from legacy doc #27972
Conversation
Replace legacy doc which is no longer updated to the current doc
There seems to be a linting failure. Would you mind addressing that in this PR? |
I can't change the js to javascript since it's a link and doing that will distort it. |
A link? |
Yes. I think it's from this 'https://reactjs' |
This doesn't look like a link to me in the markdown. It might be a github thing you're seeing. |
I did not copy the full link, I was trying to highlight where I think the problem is from. The link does contain 'js' which from the error, it says it is supposed to be 'javascript' rather. |
You should just be able to make the change and push up. |
Use full name for js language in fenced code blocks to correct linting failure.
Done. |
Because
Replace legacy documentation link which is no longer updated to the current one.
This PR
Issue
Closes #XXXXX
Additional Information
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section