Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node Pathway: Update descriptive link text (Conclusion) #27957

Merged
merged 2 commits into from
May 12, 2024
Merged

Node Pathway: Update descriptive link text (Conclusion) #27957

merged 2 commits into from
May 12, 2024

Conversation

ryanleslie1997
Copy link
Contributor

@ryanleslie1997 ryanleslie1997 commented May 10, 2024 •
edited

Because

To improve the descriptive link text for the conclusion of the Node Pathway.

This PR

  • Updated descriptive link text on lines 44, 60, 61, 62.

Issue

Related to #27819

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: NodeJS Involves the NodeJS course label May 10, 2024
MaoShizhong
MaoShizhong requested changes May 10, 2024
View reviewed changes
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for getting the two lessons sorted! Just need a fix to one link which is now dead after a recent change on Express' side.

nodeJS/final_project/conclusion.md Outdated Show resolved Hide resolved
@ryanleslie1997 @MaoShizhong
Update nodeJS/final_project/conclusion.md
d223af5 
Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>
MaoShizhong
MaoShizhong approved these changes May 12, 2024
View reviewed changes
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@MaoShizhong MaoShizhong merged commit b1aee7c into TheOdinProject:main May 12, 2024
2 of 3 checks passed
SahilMepani pushed a commit to SahilMepani/curriculum that referenced this pull request May 12, 2024
@ryanleslie1997 @MaoShizhong @SahilMepani
Node Conclusion: Update descriptive link text (Conclusion) (TheOdinPr…
909b3c3 
…oject#27957)

* Update conclusion.md

* Update nodeJS/final_project/conclusion.md

Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>

---------

Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaoShizhong MaoShizhong MaoShizhong approved these changes

Assignees
No one assigned
Labels
Content: NodeJS Involves the NodeJS course
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ryanleslie1997 @MaoShizhong