Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intro to Flexbox lesson: Remove rogue </span> text #27889

Merged
merged 2 commits into from Apr 29, 2024

Conversation

SerbanUntu
Copy link
Contributor

The tag after the first image in the lesson was separated by two newlines, causing it to be displayed as a paragraph of text in the browser, so I removed the two newlines.

Because

The space between the link to the image and the tag afterwards was too large, it caused the tag to be interpreted as a separate paragraph, leading to the visual bug.

This is a screenshot of the part of the lesson in which the visual bug occurs:
Screenshot of bug

This PR

  • Removes the two newlines before the tag after the link to the first image in the lesson to remove the </span> text from the page.

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

The </span> tag from the first image in the lesson was separated by two newlines, causing it to be displayed as a paragraph of text in the browser.
@github-actions github-actions bot added the Content: Foundations Involves the Foundations content label Apr 29, 2024
Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>
@MaoShizhong MaoShizhong merged commit 9969d1d into TheOdinProject:main Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Foundations Involves the Foundations content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants