Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced Selectors - Intermediate HTML and CSS Course: suggest article usage #27887

Merged
merged 3 commits into from Apr 30, 2024

Conversation

jayceecalata
Copy link
Contributor

@jayceecalata jayceecalata commented Apr 29, 2024

For the sake of uniformity, use 'the' article in the comments inside the child combinator snippet, similar to how it's used in the adjacent sibling combinator snippet's comments (to refer to the divs with their respective classes).

Because

Snippet comments can be more consistent

This PR

  • Change 'a' with 'the' article in some comments in a snippet to match its following snippet/s

Issue

Closes #XXXXX

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

For the sake of uniformity, use 'the' article in the comments inside the child combinator snippet, similar to how it's used in the adjacent sibling combinator snippet's comments (to refer to the divs with their respective classes).
@github-actions github-actions bot added the Content: Intermediate HTML/CSS Involves the Intermediate HTML/CSS course label Apr 29, 2024
@jayceecalata jayceecalata changed the title Update advanced_selectors.md Advanced Selectors - Intermediate HTML and CSS Course: suggest article usage Apr 29, 2024
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it's only a nit fix, I think it's a fair one, but there is a little further nit as detailed below.

jayceecalata and others added 2 commits April 30, 2024 12:29
…tors.md

Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>
…tors.md

Co-authored-by: MaoShizhong <122839503+MaoShizhong@users.noreply.github.com>
@jayceecalata
Copy link
Contributor Author

I have committed your requested changes. Is there anything else I need to do?

Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 👍

@MaoShizhong MaoShizhong merged commit 21cd3db into TheOdinProject:main Apr 30, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Intermediate HTML/CSS Involves the Intermediate HTML/CSS course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants