Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced HTML and CSS: Updated links description of three lessons #27884

Merged
merged 5 commits into from Apr 29, 2024

Conversation

thatsthat
Copy link
Contributor

Because

The links description should be sufficiently descriptive to improve accessibility.

This PR

  • Keyframes lesson: updated links description according to spreadsheet
  • Natural Responsiveness lesson: updated links description according to spreadsheet
  • Project: Homepage: updated links description according to spreadsheet

Issue

Related to #27819

Additional Information

Pull Request Requirements

  • [ x] I have thoroughly read and understand The Odin Project curriculum contributing guide
  • [x ] The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • [x ] The Because section summarizes the reason for this PR
  • [ x] The This PR section has a bullet point list describing the changes in this PR
  • [ x] If this PR addresses an open issue, it is linked in the Issue section
  • [ x] If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • [x ] If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Advanced HTML/CSS Involves the Advanced HTML/CSS course label Apr 29, 2024
@thatsthat
Copy link
Contributor Author

Should I also do some linting in addition to the required text changes provided on the spreadsheet?

@MaoShizhong MaoShizhong self-assigned this Apr 29, 2024
@MaoShizhong MaoShizhong self-requested a review April 29, 2024 11:56
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting these links fixed up @thatsthat!

There's one link missed for line 38 of Project: Homepage regarding the feedback form. Could you get this one fixed up as well?

Regarding the linting errors, in this case if you're happy to get them fixed up then that'd be awesome, thanks. Kill two birds with one stone.
I've commented below regarding my suggestion for a couple of specific errors.

The rest should be manageable if you follow the repo's contributing guide for running lint checks and fixed locally.
Most of the errors should be fixable via the appropriate fix npm script, and any remaining ones must be fixed manually (e.g. the ones I pointed out, ol prefixes etc.)

Let me know if you run into any issues with this.

Copy link
Contributor Author

@thatsthat thatsthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've fixed the linting and the extra link that I had missed

Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing up the rest of the things, looks awesome! 🚀

@MaoShizhong MaoShizhong merged commit b44437f into TheOdinProject:main Apr 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Advanced HTML/CSS Involves the Advanced HTML/CSS course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants