New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advanced HTML and CSS: Updated links description of three lessons #27884
Advanced HTML and CSS: Updated links description of three lessons #27884
Conversation
Should I also do some linting in addition to the required text changes provided on the spreadsheet? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting these links fixed up @thatsthat!
There's one link missed for line 38 of Project: Homepage
regarding the feedback form. Could you get this one fixed up as well?
Regarding the linting errors, in this case if you're happy to get them fixed up then that'd be awesome, thanks. Kill two birds with one stone.
I've commented below regarding my suggestion for a couple of specific errors.
The rest should be manageable if you follow the repo's contributing guide for running lint checks and fixed locally.
Most of the errors should be fixable via the appropriate fix npm script, and any remaining ones must be fixed manually (e.g. the ones I pointed out, ol prefixes etc.)
Let me know if you run into any issues with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I've fixed the linting and the extra link that I had missed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing up the rest of the things, looks awesome! 🚀
Because
The links description should be sufficiently descriptive to improve accessibility.
This PR
Issue
Related to #27819
Additional Information
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section