Update installing_nodejs.md #27603
Open
Update installing_nodejs.md #27603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added "Additional resources" to the lesson. Guiding people who are interested in what node is used in the industry for can watch a short video and find out.
github-actions
bot
added
the
Content: Foundations
CouchofTomato
requested review from
a team and
fortypercenttitanium
and removed request for
a team
fortypercenttitanium
requested changes
Mar 18, 2024
| @@ -138,4 +138,5 @@ To run the Node console, open up your terminal and type `node`. Type `.exit` to | |||
|
|
|||
| This section contains helpful links to related content. It isn’t required, so consider it supplemental. | |||
|
|
|||
| - It looks like this lesson doesn't have any additional resources yet. Help us expand this section by contributing to our curriculum. | |||
| - Wondering why are we installing Node? you will learn the different uses of Node in the next chapters but if you're curious, | |||
There was a problem hiding this comment.
The learner shouldn't be wondering why we're installing Node. It's answered in the first two sentences of this lesson. However, I do like the video. Why don't we say something like "If you are wanting to learn just a little bit more about NodeJS, check out this short video by Programming with Mosh."
There was a problem hiding this comment.
I updated the .md file does this satisfy your recommendation sir ?
|
Hello friend sprry to reply late... I think your idea is much better and it
will help the course to be much precise and on point, I'll start working on
it rn
Thankyou
…On Mon, 18 Mar 2024, 18:45 Alex Younger, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In foundations/javascript_basics/installing_nodejs.md
<#27603 (comment)>
:
> @@ -138,4 +138,5 @@ To run the Node console, open up your terminal and type `node`. Type `.exit` to
This section contains helpful links to related content. It isn’t required, so consider it supplemental.
-- It looks like this lesson doesn't have any additional resources yet. Help us expand this section by contributing to our curriculum.
+- Wondering why are we installing Node? you will learn the different uses of Node in the next chapters but if you're curious,
The learner shouldn't be wondering why we're installing Node. It's
answered in the first two sentences of this lesson. However, I do like the
video. Why don't we say something like "If you are wanting to learn just a
little bit more about NodeJS, check out this short video by Programming
with Mosh."
—
Reply to this email directly, view it on GitHub
<#27603 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BFRURCI7D35VJNIFMHBGGQLYY3SHLAVCNFSM6AAAAABET7G362VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNBSHEZTANRVGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
fortypercenttitanium
requested changes
Mar 27, 2024
| @@ -137,5 +137,4 @@ To run the Node console, open up your terminal and type `node`. Type `.exit` to | |||
| ### Additional resources | |||
|
|
|||
| This section contains helpful links to related content. It isn’t required, so consider it supplemental. | |||
|
|
|||
| - It looks like this lesson doesn't have any additional resources yet. Help us expand this section by contributing to our curriculum. | |||
| NodeJS in a Nutshell [What is Node js?](https://www.youtube.com/watch?v=uVwtVBpw7RQ) | |||
There was a problem hiding this comment.
Please use my earlier suggestion. We like to credit the authors of videos in the video link itself. Also, please use NodeJS instead of Node js in the future.
Credited the Video author NodeJS
|
The requested changes are done.
…On Wed, Mar 27, 2024 at 6:06 PM Alex Younger ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In foundations/javascript_basics/installing_nodejs.md
<#27603 (comment)>
:
> @@ -137,5 +137,4 @@ To run the Node console, open up your terminal and type `node`. Type `.exit` to
### Additional resources
This section contains helpful links to related content. It isn’t required, so consider it supplemental.
-
-- It looks like this lesson doesn't have any additional resources yet. Help us expand this section by contributing to our curriculum.
+NodeJS in a Nutshell [What is Node js?](https://www.youtube.com/watch?v=uVwtVBpw7RQ)
Please use my earlier suggestion. We like to credit the authors of videos
in the video link itself. Also, please use NodeJS instead of Node js in
the future.
—
Reply to this email directly, view it on GitHub
<#27603 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BFRURCI2PFNX5JZO64XH24LY2K4MTAVCNFSM6AAAAABET7G362VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNRTGE4DONRQGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
fortypercenttitanium
approved these changes
Mar 27, 2024
fortypercenttitanium
requested changes
Mar 27, 2024
There was a problem hiding this comment.
Looks like there are some linting issues now. Please investigate and address them and I will approve. Use the style guide to figure out why it was flagged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "Additional resources" to the lesson. Guiding people who are interested in what node is used in the industry for can watch a short video and find out.
Because
I was guided to install a program but for why was not actually clear. (the tutorial only says we will be using it to run the code outside a webpage but I was curious why a pro would need this so I had to go and do some research on my own. So I added the Youtube video that helped me find answers so future curious learners can get the knowledge too. Instead of "Additional resources"
This PR
Issue
Closes #
Additional Information
none
Pull Request Requirements
location of change: brief description of changeformat, e.g.Intro to HTML and CSS lesson: Fix link textBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection