Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Pathway: Provide descriptive link text #27819

Open
27 of 30 tasks
MaoShizhong opened this issue Apr 19, 2024 · 74 comments
Open
27 of 30 tasks

Node Pathway: Provide descriptive link text #27819

MaoShizhong opened this issue Apr 19, 2024 · 74 comments
Labels
Type: Accessibility Involves an accessibility feature or requires accessibility review Type: Epic This issue is a larger, unnamed project with several moving parts

Comments

@MaoShizhong
Copy link
Contributor

MaoShizhong commented Apr 19, 2024

Links in our lessons should be sufficiently descriptive to improve accessibility. As per the layout style guide, link text should both concisely describe its purpose (or where the link will redirect a user), and must not include the words this nor here.

Guidance

  • Comment on this issue to let us know you'd like to get a section assigned to you. You can also ask for a specific one.
  • Please wait until you are assigned by a maintainer before starting to work on this issue to avoid multiple people working on the same lessons.
  • When you have been assigned a section, please refer to the suggested link text changes spreadsheet for instructions on what changes need to be made for your assigned lesson(s).
    • For most of these, you should just be able to copy and paste the suggested text to replace the original text shown in the spreadsheet (which may be more than just the link itself). Any additional steps/clarifications will be noted by the appropriate link(s).
    • You are welcome to use a different wording from a given suggestion if you find a better one. If you do, you must ensure the link text is consistent if there are multiple instances of the same href in the same lesson.
    • You are not required to fix any unrelated, preexisting linting errors such as list styles/indentation. Existing linting errors may cause certain tests to fail when you open a PR. You can ignore this and a maintainer will let you know if further action is required.
  • Make sure to read the general contributing guide as well as the curriculum repo contributing guide before starting your first contribution.
  • Please add the following to your PR in the Issues section: Related to #XXXXX , since this issue is divided into sections, individual PRs should NOT INCLUDE the closes keyword.

Progress and assignees

Intermediate HTML and CSS

JavaScript

Advanced HTML and CSS

React

NodeJS

Getting Hired

@MaoShizhong MaoShizhong added Type: Good First Issue Good for beginner contributors Status: Help Wanted This issue can be assigned to other contributors Type: Accessibility Involves an accessibility feature or requires accessibility review Type: Epic This issue is a larger, unnamed project with several moving parts labels Apr 19, 2024
@strallia
Copy link
Contributor

I'd be glad to help out with this issue. Could I be assigned the React lessons "React Components && What is JSX? && Keys in React && More On State"?

@MaoShizhong
Copy link
Contributor Author

Of course you can - assigned that lesson group to you, @strallia

@Gallardo166
Copy link
Contributor

Hi, I would like to try contributing for the first time. May I take on the "More Text Styles && More CSS Properties && Advanced Selectors"?

@MaoShizhong
Copy link
Contributor Author

@Gallardo166 I've assigned you that section 🚀

@ted-miller92
Copy link

Hello, I would like to contribute to this issue as my first contribution. May I take "What is ES6? && Asynchronous Code && A Very Brief Intro to CS"?

@MaoShizhong
Copy link
Contributor Author

@ted-miller92 Assigned you that section!

@Crn0
Copy link
Contributor

Crn0 commented Apr 20, 2024

Hello, Mao! I would like to be assigned to a section if possible.

@MaoShizhong
Copy link
Contributor Author

@Crn0 assign you Emmet && SVG 🚀

@mathdebate09
Copy link
Contributor

Hey Mao, please assign me the section for "Introduction to React && Setting Up A React Environment && Reducing State"

@MaoShizhong
Copy link
Contributor Author

@mathdebate09 assigned!

@gingkapls
Copy link
Contributor

Hello Mao! I'd be glad to contribute to the lesson on Classes under Javascript.

@MaoShizhong
Copy link
Contributor Author

@gingkapls assigned!

@RichardAnthonySanchez
Copy link
Contributor

Is the ES6 modules still available? If so, may I be assigned for that lesson? Thanks in advance!

@MaoShizhong
Copy link
Contributor Author

@RichardAnthonySanchez All yours!

@ryanleslie1997
Copy link
Contributor

Hi, I'm happy to help with the API Security and Conclusion under NodeJS.

@MaoShizhong MaoShizhong removed Type: Good First Issue Good for beginner contributors Status: Help Wanted This issue can be assigned to other contributors labels May 4, 2024
@MaoShizhong
Copy link
Contributor Author

Assigned you that lesson group @ryanleslie1997!

@EdMagal
Copy link
Contributor

EdMagal commented May 10, 2024

I would like to have a section assigned to me, if there are any available yet. Thanks a lot. :)

@MaoShizhong
Copy link
Contributor Author

Sorry, @EdMagal. All lesson groups have already been assigned.

That being said, @ted-miller92 and @mrzamin just a courtesy check in to see if this is still something you wish to work on?

@ryanleslie1997
Copy link
Contributor

I managed to figure it out.

@MaoShizhong
Copy link
Contributor Author

@EdMagal would you be happy to take the following lessons?
What is ES6? && Asynchronous Code && A Very Brief Intro to CS

@EdMagal
Copy link
Contributor

EdMagal commented May 18, 2024

@EdMagal would you be happy to take the following lessons? What is ES6? && Asynchronous Code && A Very Brief Intro to CS

@MaoShizhong surely. Thanks a lot.

@MaoShizhong
Copy link
Contributor Author

In that case I'll swap the assignment for those lessons to you instead, due to no response from the original assignee.

@MaoShizhong
Copy link
Contributor Author

@jwaddell10 Just a courtesy check to see if this is still something you wish to work on. Let me know if you have any issues!

@SeanAverS
Copy link

Hello. If there are any open sections still available I would like to take one. Thank you.

@jwaddell10
Copy link
Contributor

jwaddell10 commented May 19, 2024 via email

jwaddell10 added a commit to jwaddell10/curriculum that referenced this issue May 19, 2024
updated lesson text per issue TheOdinProject#27819 recommendations
MaoShizhong pushed a commit that referenced this issue May 19, 2024
updated lesson text per issue #27819 recommendations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Accessibility Involves an accessibility feature or requires accessibility review Type: Epic This issue is a larger, unnamed project with several moving parts
Projects
None yet
Development

No branches or pull requests