Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix menu boxes in TD being too small #995

Open
wants to merge 1 commit into
base: vanilla
Choose a base branch
from
Open

Fix menu boxes in TD being too small #995

wants to merge 1 commit into from

Conversation

hazelnot
Copy link

@hazelnot hazelnot commented Apr 5, 2024 •
edited

Fixes the menu boxes being one pixel too short vertically and horizontally, as well as the small gaps in the TD DOS sidebar.

Fixes #993 and partially #756

(Thanks to @mvdhout1992 for actually fixing the code, I just implemented it)

@hazelnot hazelnot force-pushed the boxfix branch 5 times, most recently from 5b59dca to 559c637 Compare April 7, 2024 11:58
giulianobelinassi
giulianobelinassi reviewed May 20, 2024
View reviewed changes
Copy link
Collaborator

@giulianobelinassi giulianobelinassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not happy with the amount of clipping this fix does. Are the coordinates of the FillRect call actually correct for the menus?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giulianobelinassi giulianobelinassi giulianobelinassi left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TD] Menu backgrounds are all one pixel too small on the bottom and right sides
2 participants
@hazelnot @giulianobelinassi