Fix Random() for big-endian systems #987
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This might be not strictly needed, but fixes failures in tests/irandom
| bytes[1] = (bytes[1] << 1) | cf1; | ||
| cf1 = (bytes[2] >> 7) & 1; | ||
| bytes[2] = (bytes[2] << 1) | cf2; | ||
| cf2 = (tmp_a - (RandNumb + (cf1 != 1))) & 1; |
There was a problem hiding this comment.
Wouldn't this on the second iteration change RandNumb's value and then change cf2 Can you please elaborate why it works?
There was a problem hiding this comment.
The code treats the unsigned int RandNumb as a 4 byte array. So the endianness has to be taken into account (the comment already warns about this). The new code essentially does the same as the original code for big-endian systems.
Since this is supposed to generate random numbers, it does not make much difference at runtime, but the tests/irandom.cpp only works on little-endian systems.
giulianobelinassi
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be not strictly needed, but fixes failures in tests/irandom