Added a define for activating support for 'new' video code. #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vanilla Conquer had internal changes to how it handled frame rendering when SDL support was added. This code is only active for SDL builds, and not for builds with the legacy Windows video code enabled. However, this code should be used for all new video code implementations and not just SDL, so hiding it behind the SDL_BUILD is misleading and also makes it harder to add support for other platforms. Changed the compile time checks for SDL_BUILD into NEW_VIDEO_BUILD where those checks guard code that is not SDL-specific.
OmniBlade
approved these changes
Mar 20, 2024
|
I don't seem to be able to rebase this from the github UI, does it need a manual rebase @isojalka? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vanilla Conquer had internal changes to how it handled frame rendering when SDL support was added. This code is only active for SDL builds, and not for builds with the legacy Windows video code enabled. However, this code should be used for all new video code implementations and not just SDL, so hiding it behind the SDL_BUILD is misleading and also makes it harder to add support for other platforms.
Changed the compile time checks for SDL_BUILD into NEW_VIDEO_BUILD where those checks guard code that is not SDL-specific.