Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements Ramer-Douglas-Peucker simplification algorithm #710

Merged
merged 7 commits into from May 18, 2024

Conversation

Sellig6792
Copy link
Contributor

@Sellig6792 Sellig6792 commented May 2, 2024

Pull Request Template

Description

I implemented the Ramer-Douglas-Peucker algorithm. I use it in a project it works very well. This algorithm allow you to reduce the number of point of a polygon and to keep a maximum of precision.

The test doesn't make a real sesnse, since the results changes with the epsilon value.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I ran bellow commands using the latest version of rust nightly. => My code doesn't make issues
  • I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
  • I ran cargo fmt just before my last commit.
  • I ran cargo test just before my last commit and all tests passed.
  • I added my algorithm to the corresponding mod.rs file within its own folder, and in any parent folder(s).
  • I added my algorithm to DIRECTORY.md with the correct link.
  • I checked COUNTRIBUTING.md and my code follows its guidelines.

Please make sure that if there is a test that takes too long to run ( > 300ms), you #[ignore] that or
try to optimize your code or make the test easier to run. We have this rule because we have hundreds of
tests to run; If each one of them took 300ms, we would have to wait for a long time.

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.80%. Comparing base (4248281) to head (7f4e2e3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #710      +/-   ##
==========================================
+ Coverage   94.78%   94.80%   +0.01%     
==========================================
  Files         300      301       +1     
  Lines       22274    22356      +82     
==========================================
+ Hits        21113    21195      +82     
  Misses       1161     1161              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/geometry/ramer_douglas_peucker.rs Outdated Show resolved Hide resolved
src/geometry/ramer_douglas_peucker.rs Outdated Show resolved Hide resolved
src/geometry/ramer_douglas_peucker.rs Outdated Show resolved Hide resolved
src/geometry/ramer_douglas_peucker.rs Outdated Show resolved Hide resolved
src/geometry/ramer_douglas_peucker.rs Outdated Show resolved Hide resolved
src/geometry/ramer_douglas_peucker.rs Outdated Show resolved Hide resolved
src/geometry/ramer_douglas_peucker.rs Outdated Show resolved Hide resolved
src/geometry/ramer_douglas_peucker.rs Show resolved Hide resolved
src/geometry/ramer_douglas_peucker.rs Outdated Show resolved Hide resolved
src/geometry/ramer_douglas_peucker.rs Outdated Show resolved Hide resolved
@Sellig6792 Sellig6792 requested a review from vil02 May 18, 2024 17:25
@vil02 vil02 merged commit 87673f0 into TheAlgorithms:master May 18, 2024
4 checks passed
TruongNhanNguyen pushed a commit to TruongNhanNguyen/Rust that referenced this pull request May 20, 2024
…hms#710)

* Implements Ramer-Douglas-Peucker simplification algorithm

* Apply requested changes

* Cargo format

* Cargo clippy

* Apply requested changes

* style: use slice

---------

Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants