New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements Ramer-Douglas-Peucker simplification algorithm #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #710 +/- ##
==========================================
+ Coverage 94.78% 94.80% +0.01%
==========================================
Files 300 301 +1
Lines 22274 22356 +82
==========================================
+ Hits 21113 21195 +82
Misses 1161 1161 ☔ View full report in Codecov by Sentry. |
vil02
requested changes
May 10, 2024
vil02
requested changes
May 18, 2024
vil02
reviewed
May 18, 2024
vil02
approved these changes
May 18, 2024
TruongNhanNguyen
pushed a commit
to TruongNhanNguyen/Rust
that referenced
this pull request
May 20, 2024
…hms#710) * Implements Ramer-Douglas-Peucker simplification algorithm * Apply requested changes * Cargo format * Cargo clippy * Apply requested changes * style: use slice --------- Co-authored-by: Piotr Idzik <65706193+vil02@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
I implemented the Ramer-Douglas-Peucker algorithm. I use it in a project it works very well. This algorithm allow you to reduce the number of point of a polygon and to keep a maximum of precision.
The test doesn't make a real sesnse, since the results changes with the epsilon value.
Type of change
Please delete options that are not relevant.
Checklist:
cargo clippy --all -- -D warnings
just before my last commit and fixed any issue that was found.cargo fmt
just before my last commit.cargo test
just before my last commit and all tests passed.mod.rs
file within its own folder, and in any parent folder(s).DIRECTORY.md
with the correct link.COUNTRIBUTING.md
and my code follows its guidelines.Please make sure that if there is a test that takes too long to run ( > 300ms), you
#[ignore]
that ortry to optimize your code or make the test easier to run. We have this rule because we have hundreds of
tests to run; If each one of them took 300ms, we would have to wait for a long time.