refactor: simplify logic of Point::equals in KDTree
#5158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Java into enable_EqualsHashCode style: enable EqualsHashCode in Checkstyle
CodaBlurd
requested review from
yanglbme,
vil02 and
BamaCharanChhandogi
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5158 +/- ##
=========================================
Coverage 38.24% 38.24%
Complexity 2361 2361
=========================================
Files 516 516
Lines 15305 15304 -1
Branches 2957 2956 -1
=========================================
Hits 5853 5853
Misses 9165 9165
+ Partials 287 286 -1 ☔ View full report in Codecov by Sentry. |
vil02
changed the title
Point::equals in KDTree
vil02
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #5157 (comment).