Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make issue: add ADDITIONAL_FILES that can list extra files needed for make issue #2001

Merged
merged 1 commit into from May 11, 2024
Merged

make issue: add ADDITIONAL_FILES that can list extra files needed for make issue #2001

merged 1 commit into from May 11, 2024

Conversation

oharboe
Copy link
Collaborator

@oharboe oharboe commented May 10, 2024

@lpawelcz Fixes the error below.

make DESIGN_CONFIG=designs/asap7/mock-array/Element/config.mk io_placement_random_issue

Results in:

$ ./run-me-mock-array_Element-asap7-base.sh 
OpenROAD v2.0-13652-g6fc686431 
Features included (+) or not (-): +Charts +GPU +GUI +Python
This program is licensed under the BSD-3 license. See the LICENSE file for details.
Components of this program may be licensed under more restrictive licenses which must be honored.
[ERROR STA-0340] cannot open 'designs/src/mock-array/util.tcl'.
Error: io.tcl, 1 STA-0340
openroad>

@oharboe oharboe requested a review from maliberty May 10, 2024 06:45
@oharboe
make issue: add ADDITIONAL_FILES that can list extra files needed for…
25321a3 
… make issue

Also added a quick smoke-test of make issue in test/test_make_issue.sh,
but didn't find anywhere to hook it up in OpenROAD-flow-scripts.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
@oharboe oharboe force-pushed the make-issue-additional-files branch from 44f0c1d to 25321a3 Compare May 10, 2024 07:32
@maliberty maliberty merged commit 480648d into The-OpenROAD-Project:master May 11, 2024
5 checks passed
@oharboe
Copy link
Collaborator Author

oharboe commented May 11, 2024

@maliberty Can you have arranged for the new test to be added to CI?

@maliberty
Copy link
Member

@maliberty Can you have arranged for the new test to be added to CI?

@vvbandeira when you have a time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maliberty maliberty maliberty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oharboe @maliberty