Don't mirror isAccessibilityElement on _ASTableViewCell #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a partial revert of TextureGroup#1941 The change in TextureGroup#1941 has caused some issues for us and others (see TextureGroup#1997). If I set `myNode.isAccessibilityElement = true,` then what ends up happening is that the table cell wrapper view (_ASTableViewCell) also has `isAccessibilityElement = true`. But then when iOS goes through the hierarchy it identifies the table cell wrapper view as the target and attempts to use that accessibilityLabel, which doesn't exist (because it's actually on the nested node view). So our node's label is never used. I'm not sure why setting `isAccessibilityElement` in `_ASTableViewCell` was necessary in TextureGroup#1941 in order to make a node non-accessible, since the default value is already false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial revert of #1941
The change in #1941 has caused some issues for us and others (see #1997). If I set
myNode.isAccessibilityElement = true,then what ends up happening is that the table cell wrapper view (_ASTableViewCell) also hasisAccessibilityElement = true. But then when iOS goes through the hierarchy it identifies the table cell wrapper view as the target and attempts to use that accessibilityLabel, which doesn't exist (because it's actually on the nested node view). So our node's label is never used.I'm not sure why setting
isAccessibilityElementin_ASTableViewCellwas necessary in #1941 in order to make a node non-accessible, since the default value is already false.