Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cartfile to use PINRemoteImage master branch to support Xcode 12 #1908

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

udayasri
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Sep 17, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Cartfile Outdated
github "pinterest/PINRemoteImage" "3.0.0-beta.14"
github "pinterest/PINCache" "3.0.1-beta.7"
github "pinterest/PINRemoteImage" "master"
github "pinterest/PINCache" "master"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My gut feeling tells me that these should not be pinned to master. The Podspec has 3.00 for PINRemoteImage, and 3.0.1-beta.8 for PINCache.

@MeGaPk
Copy link

MeGaPk commented Sep 21, 2020

set "master" like a version, it's very bad idea....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants