Feature info chart fixes.

[na9da]

What this PR does

Alternate approach to #6960 for making y-column of feature info charts configurable.

This PR

• allows y-columns to be used with <chart> component in feature info templates without changing the merge strategy of chart traits. It does it by passing the y-column as a prop to the FeatureInfoPanelChart.
• TSifies FeatureInfoPanelChart and purges some scss it depends on.
• Default label on x-axis will now say ${y-column-name}(${y-units}) x ${x-column-name}(${x-units})

Test me

• Same behaviour as main when a y-column is specified.
  • Feature info panel for this branch should be the same as main.
• Same behaviour as main when no y-column is specified
  • Feature info panel for this branch should be the same as main
• DEA coastlines chart
  • Check if the feature info panel chart is rendered correctly, can be expanded, downloaded and toggled from the workbench chart selector list
• DEA water bodies chart
  • Check if the feature info panel chart is rendered correctly, can be expanded, downloaded and toggled from the workbench chart selector list

Checklist

• There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
• I've updated relevant documentation in doc/.
• I've updated CHANGES.md with what I changed.
• I've provided instructions in the PR description on how to test this PR.

[mwu2018]

@na9da I've verified the above testing examples. Also have verified with my own datasets. They all work nicely.

[na9da]

Same as before but just convinces TS that value is not undefined when using yColumnId below.

[na9da]

Use styled-components.

[na9da]

Pass y-column as prop to the FeatureInfoPanelChart

[nf-s]

I feel like adding a y-column to FeatureInfoPanelChart kind of skips the TableStyle system. This behaviour is different from ChartView/ChartPanel - which uses ChartItem.showChartInPanel to determine which charts should be showing.

Ideally CsvChartCustomComponent y-columns attribute is used to set TableChartLineStyleTraits.isSelectedInWorkbench - and then FeatureInfoPanelChart shows the first applicable chart item.

What do you think?

[nf-s]

I also wonder if it is worth reverting

• Add MergeStrategy to objectArrayTrait #6960

if it is no longer needed here - as this was the only use of MergeStrategy.TopStratum. How strata is merged is hairy, and I'm not convinced that it was the best approach - it might be better to visit the problem more holistically later

[nf-s]

After discussion: it is difficult to do what I suggested - so merge this in as short-term solution

[na9da]

For more context, the reason why we are not able to implement the recommended fix to use isSelectedInWorkbench trait is that isSelectedInWorkbench is automatically set to true here for the first column:

terriajs/lib/Table/TableAutomaticStylesStratum.ts

Lines 162 to 165 in b73909e

	createStratumInstance(TableChartLineStyleTraits, {
	yAxisColumn: column.name,
	isSelectedInWorkbench: i === 0 // activate only the first chart line by default
	})

To override that programmatically, we'll need to know what columns exists, but that is not known until the chart catalog item is loaded here in FeatureInfoPanelChart. It is easier then, to just pass the chosen y-column as a prop.