Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move strings from RelatedMaps to translation.json #7154

Merged
merged 2 commits into from
May 14, 2024
Merged

Move strings from RelatedMaps to translation.json #7154

merged 2 commits into from
May 14, 2024

Conversation

steve9164
Copy link
Member

@steve9164 steve9164 commented May 14, 2024 •
edited

What this PR does

Move strings to translation.json. This doesn't add translation support for RelatedMaps content.

Test me

View http://ci.terria.io/translate-related-maps and test button name, title and panel text

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

@mwu2018 mwu2018 merged commit b2209bb into main May 14, 2024
9 checks passed
@mwu2018 mwu2018 deleted the translate-related-maps branch May 14, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwu2018 mwu2018 mwu2018 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@steve9164 @mwu2018