Provide ambient types or TSify some js[x] files. #7114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
na9da
changed the title
This is needed when building terriajs from outside, like from terriamap.
pjonsson
reviewed
May 1, 2024
| "lodash-es": "^4.17.11", | ||
| "markdown-it": "^11.0.0", | ||
| "markdown-it": "^14.1.0", |
There was a problem hiding this comment.
I had this in my pile of security fixes, this fixes CVE-2022-21670.
steve9164
reviewed
May 2, 2024
lib/Core/arrayContains.ts
Outdated
Comment on lines
1
to
8
| export default function arrayContains<T>(array: readonly T[], value: T) { | ||
| for (let i = 0; i < array.length; ++i) { | ||
| if (array[i] === value) { | ||
| return true; | ||
| } | ||
| } | ||
| return false; | ||
| } |
There was a problem hiding this comment.
I've removed this (only used in 1 place in terriajs) and replaced with Array.prototype.includes.
| @@ -449,8 +447,6 @@ export default class ViewState { | |||
| } | |||
| ); | |||
|
|
|||
| this._disclaimerHandler = new DisclaimerHandler(terria, this); | |||
There was a problem hiding this comment.
This was used in v7 for showing catalog item initial message. In v8 this is handled here:
terriajs/lib/ModelMixins/MappableMixin.ts
Lines 175 to 179 in d4ccee3
| !e.dataTransfer.types || | ||
| !arrayContains(e.dataTransfer.types, "Files") | ||
| ) { | ||
| if (!e.dataTransfer.types || !e.dataTransfer.types.includes("Files")) { |
There was a problem hiding this comment.
I've made this change to remove arrayContains
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Currently, running
tscfrom an external library like a plugin fails with many... element implicitly has type "any"errors. This is becausetscwill not type check js/jsx modules from external libraries innode_modules. These errors can be suppressed by turning off noImplicitAny option, however this is pretty unsafe.This PR tries not to change any functionality, instead we typify just enough files so that
tscwill succeed without having to add any extra configuration. We make the following specific modifications:.js[x]files to.ts[x]and make necessary changes so that it type checks.js[x]files, we create an ambient.d.tsfile with type signatures for all the exportsmarkdown-itandlinkify-itso that we canimporttheir ESM versions and typings.Test me
Please just do a random test adding different catalog items, via catalog explorer, web url and drag-n-drop, open feature info panel, charts etc.
Checklist
There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)Fixed broken specs.doc/.