Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spuriuos return #7104

Merged
merged 1 commit into from May 1, 2024
Merged

Remove spuriuos return #7104

merged 1 commit into from May 1, 2024

Conversation

pjonsson
Copy link
Contributor

@pjonsson pjonsson commented Apr 8, 2024

What this PR does

Return as the last statement
of a function without return value
is not required, so remove it.

Test me

Tested by CI.

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

@steve9164
Copy link
Member

Hi @pjonsson. Thanks for the PR. The PR check failures are unrelated to your contribution, and should be fixed for future PRs soon.

@pjonsson
Copy link
Contributor Author

pjonsson commented Apr 8, 2024

@steve9164 sorry, I didn't see your comment, I just filed #7106 for that.

Return as the last statement
of a function without return value
is not required.
@nf-s
Copy link
Contributor

nf-s commented May 1, 2024

Thanks @pjonsson !

@nf-s nf-s merged commit 9845f42 into TerriaJS:main May 1, 2024
6 checks passed
@pjonsson pjonsson deleted the remove-return branch May 1, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants