Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thredds palettes #7059
base: main
Are you sure you want to change the base?
Thredds palettes #7059
Changes from 6 commits
e09266a
33e4694
ad99869
f00d68a
7e2b20e
1db060e
9eefa33
1a477f4
1227d07
ecabd69
dc1a2b5
3e23262
e9209ff
54b4420
1d22d63
843ab42
086f24b
edc06b2
38c8c9d
a14d46e
0fd38b8
9f91a7d
41892d2
722db12
2528d60
bacefe0
0dfd466
283bda1
f8d87f0
c07fb88
e8fc7b6
2ee6c8f
d8d11b6
2ddd71c
d06645c
545cf4b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this anonymous function get called?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That one is an IIFE -- I used it so I can call the async fetchPalettes without having to make the parent function async
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking that one up Lawrence, it was never getting called, removed that code block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless we also return here the fetch below will still execute and make a request to
<ur>/undefined
Should No url in the abstract be treated as an error? My understanding is it's an option property for thredds wms's so it might instead be more appropriate to
resolve([])
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to resolve, thanks Lawrence
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a condition here to
fetchPalettes
is only called if the server supports it?Currently, if you select a style for a non-THREDDs WMS - this causes an uncaught error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this comment doesn't make sense with all the other changes I have suggested