New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wps value range #7033
Wps value range #7033
Conversation
Thanks @sixlighthouses - could you point me at your mock wps please? CORS getting in the way here. |
ProcessDescriptionCsiro.zip then I can use in the add web data input for terria |
@sixlighthouses - just doing a quick pass - great start. A couple of behaviors that would be nice to add.
Can discuss how we might be able to implement them. |
@na9da I added an overridden isValid check to NumberParameter and also a rangeDescription to add the should be between min max text in the input label. Please have a look when you get a chance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @sixlighthouses . Ready to merge 🚀
* refactor the DateTimeParameterEditor to be a functional component * add the proptypes check to appease the tests * format and minor code tidy * update CHANGES.MD * add the currentTime from timelineStack as the default date time in WPS params * no need to set dateValue when declaring it with useState * Add a NumberParameterEditor to allow for the setting of a min-max range * make NumberParameterEditor a functional component and add the DefaultValue from WPS as the initial value * update CHANGES.MD * add entry to CHANGES * set default on load and override isValid in NumberParameter * undo ParameterEditor change * run prettier checks * add rangeDescription check to ParameterEditor * use super.isValid in NumberParameter * remove scss button style and implement PR feedback for NumberParameter * fix type issue * update CHANGES * remove changes to DateTimeParameters.jsx from this branch and reset CHANGES * remove entries from CHANGES
What this PR does
Fixes #6897
Implement AllowedValue Range with DefaultValue Support for WPS Parameters
This PR introduces support for allowed value ranges in the Web Processing Service (WPS) parameters. This feature allows users to specify a minimum and maximum value for number types of parameters in WPS and have those honoured in the input parameters rendered by Terria
This feature will improve the user experience by providing more control over the input parameters and preventing errors due to values outside of the acceptable range.
Renders the following
Test me
Test branch at http://ci.terria.io/wps-value-range
If you do not have a WPS available with the required parameters, let me know I have a mock wps server that allows for testing
Checklist
doc/
.