Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor the DateTimeParameterEditor to be a functional component #7021

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sixlighthouses
Copy link
Contributor

@sixlighthouses sixlighthouses commented Jan 5, 2024

What this PR does

Fixes #6896

This is a description of what I've done in this PR, especially explaining choices made to make the reviewer's job easier. If I don't replace this paragraph with an actual description, my PR will probably be ignored.

Test me

Browse to
http://ci.terria.io/wps-time-reset/#share=s-bRTdoGD1E1hSA95nLCVwIEjNXa9

From the My Data tab select the AWAVEA WPS service and then the Wave: Annual Bivariate Probability Distribution service

Select a point location, manually edit the start and end times. Update the times manually several times to test that the other unedited values do not change.

image

Ensure the debugging console is open on the Network tab, hit Run Analysis

confirm the Payload of the request has the Date Time correctly formatted as YYYY-MM-DDThh:mm

image

Checklist

  • There are unit tests to verify my changes are correct
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

@sixlighthouses sixlighthouses marked this pull request as ready for review January 9, 2024 00:33
@sixlighthouses
Copy link
Contributor Author

@nf-s please hold off on reviewing this PR -- I think this one #7026 once out of draft will cover both #6895 and #6896

@nf-s nf-s removed their assignment Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WPS: Date or time widget reset after typing in values is unexpected (chrome)
2 participants