Fix proxy POST #168
Merged
Fix proxy POST #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to change in meaning of 'close' event, which was changed to match the Stream interface instead of events of the socket
pjonsson
reviewed
May 13, 2024
| @@ -18,7 +18,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| node-version: [18.x, 20.x, 21.x] | |||
| node-version: [16.x, 18.x, 20.x, 22.x] | |||
There was a problem hiding this comment.
Node 16 had its security support end 8 months ago, how long do you plan to support it?
mwu2018
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 16 changed when the "close" event of IncomingMessage
reqis fired. This used to be fired when the socket was closed before the request finished. Now, to better match the ReadableStream interface, it is fired when the stream representing the downstream request (from TerriaMap) closes - i.e. when the entire request has been parsed by node.js - so this event is now fired for every request and in most cases before the proxied request has finished. Since our proxy controller aborts the upstream request on this event, that means that our proxy controller is now trying to abort every upstream request. This seems to only affect POST requests, but it's possible it could affect GET requests in certain cases.The fix included here is to rather use the "close" event of the ServerResonse
res. This stream will be closed after a successfully finished response, or if the socket is closed.