Adding multitask feature #2353
Merged
Adding multitask feature #2353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
avancinirodrigo
commented
Aug 11, 2020
•
avancinirodrigo
commented
- Migrate the kernel to multitask #2338
pedro-andrade-inpe
requested changes
Sep 19, 2020
src/hpa/hpa.cpp
Outdated
| HPA::~HPA(){ | ||
| if(mainStack) { | ||
| if( mainStack->getState() ) removeWorkers(mainStack->getState()); | ||
| removeLockSections(); |
| //informacao sobre a quantidade de cores da maquina | ||
| SYSTEM_INFO sysinfo; | ||
| GetSystemInfo(&sysinfo); | ||
| setNumCpu(sysinfo.dwNumberOfProcessors); |
There was a problem hiding this comment.
Does it always use all processors available?
There was a problem hiding this comment.
It would be interesting if the user could choose the amount of processors to be used.
There was a problem hiding this comment.
There is a method for that np(). See it in hpa cmd tests.
src/hpa/parserHPA.cpp
Outdated
| try{ | ||
| fileModel.open(modelPath.c_str(), ifstream::in); | ||
| }catch(exception e){ | ||
| cout << "problema ao abrir o modelo, verifique o path" << endl; |
There was a problem hiding this comment.
Please translate to english at least the messages.
| end | ||
|
|
||
| function fillCsB() | ||
| forEachCell(csB, function(cell) |
There was a problem hiding this comment.
I was thinking about having a forEachParallelCell(). Would that be possible?
There was a problem hiding this comment.
I think so, but it doesn't work with a cellular space as an argument.
There was a problem hiding this comment.
Probably something that needs to be done in C++ level.
pedro-andrade-inpe
approved these changes
Sep 21, 2020
|
@avancinirodrigo, thanks. May I merge? |
Yes. |
|
Maybe you should try to call the function received as an argument by
ForEcahCell in parallel, not the opposite:
I do not remember the exact API of HPA, so consider the code below as a
pseudocode.
parallel_forEachCell(csA, f)
for cell in pairs(csA) do
hpa:parallel( "f", cel )
end
hpa:synchronize("f")
end
Something more...
I am not sure that HPA cannot receive Celluspces or tables as parameters of
parallel functions. It can just be a bug in the new version. However,
passing big tables to parallel functions could be a mistake due to the
necessary copy of parameters to the thread´s lua stack. HPA was designed to
see CellularSpaces as shared variables where several
functions/agents/automatons make simultaneous changes (SIMD or MIMD
parallelism models). We avoid copying large cellular spaces for preventing
memory/stack overflow. We believe that the majority of models that requires
high performance computing are very prone to deal with large geographical
regions or use high resolution spatial data.
…--
Prof. Dr. Tiago Garcia de Senna Carneiro
TerraLAB - Earth System Modelling and Simulation Laboratory
Computer Science Department, UFOP - Federal University of Ouro Preto
Campus Universitário Morro do Cruzeiro, Ouro Preto - MG, Brazil, 35400-000
+55 31 3559 1692 +55 31 3559 1253
www.decom.ufop.br/terralab www.decom.ufop.br
Em seg., 21 de set. de 2020 às 13:40, Pedro R. Andrade <
notifications@github.com> escreveu:
***@***.**** commented on this pull request.
------------------------------
In test/scripts/hpa-matrix-mult.lua
<#2353 (comment)>:
> + local csA = CellularSpace {
+ xdim = dim
+ }
+
+ local csB = CellularSpace {
+ xdim = dim
+ }
+
+ function fillCsA()
+ forEachCell(csA, function(cell)
+ cell.value = dim
+ end)
+ end
+
+ function fillCsB()
+ forEachCell(csB, function(cell)
Why not?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2353 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAR547BEARQN55YYXK2TBU3SG56YJANCNFSM4P3C6GRA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.