Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(back-top): sfc to tsx #1333

Merged
merged 5 commits into from
May 30, 2024
Merged

refactor(back-top): sfc to tsx #1333

merged 5 commits into from
May 30, 2024

Conversation

liweijie0812
Copy link
Collaborator

@liweijie0812 liweijie0812 commented Apr 23, 2024

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • feat(BackTop): sfctsx

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

Copy link
Contributor

github-actions bot commented Apr 23, 2024

完成

@anlyyao
Copy link
Collaborator

anlyyao commented Apr 25, 2024

@liweijie0812 示例返回顶部无效,要额外处理一下~

@liweijie0812
Copy link
Collaborator Author

😂发现这bug存在好久了

@anlyyao
Copy link
Collaborator

anlyyao commented Apr 26, 2024

😂发现这bug存在好久了

是的 我也是在review的时候 才发现的,看了下记录,确实是历史遗留问题 😂

@anlyyao anlyyao merged commit cecf3d5 into develop May 30, 2024
10 checks passed
@anlyyao anlyyao deleted the refactor/back-top/tsx branch May 30, 2024 12:04
@github-actions github-actions bot mentioned this pull request Jun 4, 2024
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants