Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(search): 新增自动完成项预览列表. (#2432) #2520

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

feat(search): 新增自动完成项预览列表. (#2432) #2520

wants to merge 3 commits into from

Conversation

byq1213
Copy link
Contributor

@byq1213 byq1213 commented Dec 27, 2023 •
edited by zuiaiwanqian

fix #2432

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#2432

💡 需求背景和解决方案

📝 更新日志

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

jarmywang
jarmywang requested changes Dec 27, 2023
View reviewed changes
Copy link
Collaborator

@jarmywang jarmywang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1、search.wxml中key不对
2、type.ts中缺少注释
3、预览列表建议增加点击效果以及点击后收起
4、新增的属性与事件要补充到readme
5、建议item的字体、颜色增加css变量

@jarmywang
Copy link
Collaborator

jarmywang commented Dec 27, 2023 •
edited

企业微信截图_617bfb6e-c1e3-4687-82ca-56a77fc443df @RADWIMPS426 麻烦设计师看一下样式及交互

@RADWIMPS426
Copy link
Collaborator

@Wen1kang

@RADWIMPS426
Copy link
Collaborator

企业微信截图_617bfb6e-c1e3-4687-82ca-56a77fc443df @RADWIMPS426 麻烦设计师看一下样式及交互

企业微信截图_c2208765-9db6-4dc2-af64-8c1287d349a3

1.联想结果应该是要左对齐分割线

2.联想关联字符颜色要高亮才行

3.现在不知道这个单元格的高度，需要二次确认

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarmywang jarmywang jarmywang requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Search] 搜索框自动完成
4 participants
@byq1213 @jarmywang @RADWIMPS426 @anlyyao