修复QMUIToastView设置Frame时可能会循环调用的问题 #1212
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
removeFromSuperViewWhenHide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
见此issue：#1186
1、此PR是通过设置约束来实现的，我看QMUI里基本没有约束相关的代码，可能不符合QMUI的设计思路。
2、实现方式也可以采用
hook QMUIToastView.superview的layoutSubviews的形式，通过+ (nullable NSArray <QMUIToastView *> *)allToastInView:(UIView *)view方法来拿到toastViews，设置Frame