Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Newtonsoft.Json with System.Text.Json #1368

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

Replace Newtonsoft.Json with System.Text.Json #1368

wants to merge 14 commits into from

Conversation

tuscen
Copy link
Member

@tuscen tuscen commented Mar 27, 2024

No description provided.

@Fedorus
Copy link
Member

Fedorus commented Mar 31, 2024 •
edited

  1. ApiResponse contains private setters that does not allow deserialization of any object
  2. DeleteWebhook() does not contain "Result", so we have issues with it

@tuscen
Fix serialization issues
b97ffcc
@tuscen
Fix serialization errors
3ec5e12
@tuscen
Fix integration tests
f860b6e
@tuscen
Merge branch 'refs/heads/develop' into tuscen/stj-3
b751ff8 
# Conflicts:
#	src/Telegram.Bot/Requests/Available methods/Messages/Location/SendLocationRequest.cs
#	src/Telegram.Bot/Requests/Available methods/Messages/Location/SendVenueRequest.cs
#	src/Telegram.Bot/Requests/Available methods/Messages/SendAnimationRequest.cs
#	src/Telegram.Bot/Requests/Available methods/Messages/SendAudioRequest.cs
#	src/Telegram.Bot/Requests/Available methods/Messages/SendChatActionRequest.cs
#	src/Telegram.Bot/Requests/Available methods/Messages/SendContactRequest.cs
#	src/Telegram.Bot/Requests/Available methods/Messages/SendDiceRequest.cs
#	src/Telegram.Bot/Requests/Available methods/Messages/SendDocumentRequest.cs
#	src/Telegram.Bot/Requests/Available methods/Messages/SendMediaGroupRequest.cs
#	src/Telegram.Bot/Requests/Available methods/Messages/SendMessageRequest.cs
#	src/Telegram.Bot/Requests/Available methods/Messages/SendPhotoRequest.cs
#	src/Telegram.Bot/Requests/Available methods/Messages/SendPollRequest.cs
#	src/Telegram.Bot/Requests/Available methods/Messages/SendVideoNoteRequest.cs
#	src/Telegram.Bot/Requests/Available methods/Messages/SendVideoRequest.cs
#	src/Telegram.Bot/Requests/Available methods/Messages/SendVoiceRequest.cs
#	src/Telegram.Bot/Requests/Games/SendGameRequest.cs
#	src/Telegram.Bot/Requests/Stickers/CreateNewStickerSetRequest.cs
#	src/Telegram.Bot/Requests/Stickers/SendStickerRequest.cs
#	src/Telegram.Bot/Types/ReplyMarkups/KeyboardButtonRequestChat.cs
#	src/Telegram.Bot/Types/StickerSet.cs
#	src/Telegram.Bot/Types/UsersShared.cs
#	test/Telegram.Bot.Tests.Unit/EnumConverter/UpdateTypeConverterTests.cs
#	test/Telegram.Bot.Tests.Unit/Serialization/InputStickerSerializationTests.cs
@tuscen
Update serialization metadata to use STJ
6286831
@tuscen
Fix tests
541b707
@tuscen
Update version
72f0781
@tuscen
Copy link
Member Author

tuscen commented Apr 9, 2024

/azp run external-release-publish

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@tuscen tuscen marked this pull request as ready for review April 9, 2024 18:26
@tuscen tuscen linked an issue Apr 11, 2024 that may be closed by this pull request
ASP.NET Core 3.1+ compatibility #835
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ASP.NET Core 3.1+ compatibility
2 participants
@tuscen @Fedorus