Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Karb0f0s/fix queued update receiver #1186

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Karb0f0s/fix queued update receiver #1186

wants to merge 9 commits into from

Conversation

karb0f0s
Copy link
Member

@karb0f0s karb0f0s commented Jan 9, 2023

fix #1185

@karb0f0s
Copy link
Member Author

karb0f0s commented Jan 9, 2023

Even though Count property is available for ChannelReader since .NET 5 it has implementation only if channel is BoundedChannel or if it doesn't have SingleReader = true specified. More here

@karb0f0s
Copy link
Member Author

karb0f0s commented Jan 9, 2023

Apparently I suck at asynchronous programming. Now we have deadlock in QueuedUpdateReceiverTests.cs: ReceivingIsCanceledOnExceptionIfThereIsNoErrorHandler. I guess it's due almost simultaneous execution of MoveNextAsync and catch section of ReceiveUpdatesAsync.

@karb0f0s karb0f0s linked an issue Jan 22, 2023 that may be closed by this pull request
Flaky test QueuedUpdateReceiverTests.cs:UncaughtExceptionIsStoredIfErrorHandlerThrows #1185
Open
@karb0f0s karb0f0s requested a review from tuscen February 6, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuscen tuscen Awaiting requested review from tuscen

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky test QueuedUpdateReceiverTests.cs:UncaughtExceptionIsStoredIfErrorHandlerThrows
1 participant
@karb0f0s