Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tio server #8659

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Tio server #8659

wants to merge 25 commits into from

Conversation

litongjava
Copy link

Please see readme.md

@litongjava
Copy link
Author

All code has been completed and tested in the local environment, please review

@litongjava
Copy link
Author

All code has been completed and tested in the local environment, please review again

@litongjava
Copy link
Author

I've been submitting this for days, why is there no response?

@joanhey
Copy link
Contributor

joanhey commented Dec 30, 2023

Read the issues for the delay

Review

Delete any file unnecessary for the bench:

  • SQL file (hello_world.sql)
  • Bin file in tests (test/java/新建日记本文档.jnt)
  • ...

Happy new year !

joanhey
joanhey suggested changes Dec 30, 2023
View reviewed changes
Copy link
Contributor

@joanhey joanhey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete the binary in test/java, unnecesary for the bench.

frameworks/Java/tio-server/sql/hello_world.sql
@@ -0,0 +1,76 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete hello_world.sql, as it's an unnecessary extra file for the bench.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@litongjava
Copy link
Author

hello.when is the next test time?

@joanhey
Copy link
Contributor

joanhey commented May 22, 2024

This PR don't pass the tests.
You need to fix it to pass the tests before is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joanhey joanhey joanhey requested changes

Assignees
No one assigned
Labels
PR: Please Update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@litongjava @joanhey