Fixed custom skins, the color does not work on some DLabel's. #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ext_dark. There was a bug in which this did not work, the entire text was black by default, on different topics. I have a black derma theme, in which this variable is replaced, but it does not work. Screenshot (fixed): https://i.imgur.com/hNnujQ8.png
SticklyMan
reviewed
Jul 24, 2021
| @@ -545,11 +547,12 @@ function xlib.makeslider( t ) | |||
| pnl.TextArea.selectAll = t.selectall | |||
| pnl.Label:SizeToContents() | |||
| pnl:SetZPos( t.zpos or 0 ) | |||
| if t.skin then pnl.Label:SetSkin( t.skin ) end | |||
There was a problem hiding this comment.
Suggested change
| if t.skin then pnl.Label:SetSkin( t.skin ) end | |
| if t.skin then pnl:SetSkin( t.skin ) end |
Applying a skin should take effect on the whole slider. This should also set the skin of the label, right? (it's been a while for me lol)
|
Would you mind linking the SKIN you're using to test this? The ones I have for testing don't seem to handle |
https://steamcommunity.com/sharedfiles/filedetails/?id=1597409940 |
|
@SticklyMan - When you get the chance, can you follow up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SKIN.text_dark does not hook with custom skins.
There was a bug in which this did not work, the entire text was black by default, on different topics. I have a black derma theme, in which this variable is replaced, but it does not work.
Screenshot (fixed): https://i.imgur.com/hNnujQ8.png