Youtube kiosk (Trending Music) addition Issue #8801 NewPipe (Partial Solution) #955
Conversation
CaptSzat
changed the title
| assertTrue(LinkHandlerFactory.acceptUrl("https://www.youtube.com/feed/trending/music")); | ||
| assertTrue(LinkHandlerFactory.acceptUrl("https://www.youtube.com/feed/trending/music/?adsf=fjaj#fhe")); | ||
| assertTrue(LinkHandlerFactory.acceptUrl("http://www.youtube.com/feed/trending/music/")); | ||
| assertTrue(LinkHandlerFactory.acceptUrl("www.youtube.com/feed/trending/music")); | ||
| assertTrue(LinkHandlerFactory.acceptUrl("youtube.com/feed/trending/music")); | ||
| assertTrue(LinkHandlerFactory.acceptUrl("youtube.com/feed/trending/music/?akdsakjf=dfije&kfj=dkjak")); | ||
| assertTrue(LinkHandlerFactory.acceptUrl("https://youtube.com/feed/trending/music")); | ||
| assertTrue(LinkHandlerFactory.acceptUrl("m.youtube.com/feed/trending/music")); | ||
|
|
||
| assertTrue(LinkHandlerFactory.acceptUrl("https://www.invidio.us/feed/trending/music")); | ||
| assertTrue(LinkHandlerFactory.acceptUrl("https://invidio.us/feed/trending/music")); | ||
| assertTrue(LinkHandlerFactory.acceptUrl("invidio.us/feed/trending/music")); |
There was a problem hiding this comment.
None of these links actually work, not sure if we should be doing these. They all use the /feed/trending path.
| // @formatter:off | ||
| final byte[] body = JsonWriter.string(prepareDesktopJsonBuilder(getExtractorLocalization(), | ||
| getExtractorContentCountry()) | ||
| .value("browseId", "MUtrending") |
There was a problem hiding this comment.
I tried looking for this browseId everywhere, on youtube.com and music.youtube.com (There's no trending page at all).
What I found out is that the official client uses a browseId of FEtrending with the params as 4gINGgt5dG1hX2NoYXJ0cw%3D%3D, which is URL and base64 encoded protobuf.
The protobuf decoded looks like this:
I think we should change this to follow the official client.
There was a problem hiding this comment.
music: '4gINGgt5dG1hX2NoYXJ0cw%3D%3D',
gaming: '4gIcGhpnYW1pbmdfY29ycHVzX21vc3RfcG9wdWxhcg%3D%3D',
movies: '4gIKGgh0cmFpbGVycw%3D%3D'
|
@FireMasterK could you take care of having this PR merged? You know extractor/YouTube code better than me ;-). Also look at TeamNewPipe/NewPipe#8801 (comment). @CaptSzat try to change the request parameters as @FireMasterK said :-) |
This comment was marked as spam.
This comment was marked as spam.
Added Youtube Muisc Trending Kiosk but unable to get a link to the YouTube music trending page so the Youtube Trending Music kiosk diusplays Trending feed until a fix can be found.
NewPipe PR: TeamNewPipe/NewPipe#9200