Made YouTube service proxyable/pluggable and add support for invidious #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
litetex
added
youtube
12 tasks
litetex
force-pushed
the
invidious
branch
2 times, most recently
from
675c74c
to
b697961
Compare
This was referenced Apr 26, 2022
1 task
* allows usage of YouTubeLike services, e.g. invidious * simplified some classes/code * Added support for invidious * Some credits go to @B0pol's PR TeamNewPipe#555 for that ;)
Removed suppression file and use inline comments: Modifying the suppression file is no longer required when moving code in affected classes
* Dislikes are always 0
Also uses parameterized tests now
litetex
added a commit
to litetex/NewPipeExtractor
that referenced
this pull request
Aug 7, 2022
litetex
added a commit
to litetex/NewPipeExtractor
that referenced
this pull request
Aug 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #427
Description
This PR make the YouTube service proxyable/pluggable.
What does this mean?
It means that the YouTubeService behaves as a proxy for a YouTubeLikeService, which can be set into there.
Currently the following services are implemented:
YouTubeDirectService- Directly calls YouTube - was previously theYouTubeServiceInvidiousService- Uses Invidious/anInvidiousInstanceto access YouTubeThe current implementation also allows implementing of further service like e.g. Piped that proxy YT.
The merging of these PR should avoid total "NewPipe blackouts" like e.g. TeamNewPipe/NewPipe#8202 as it makes the user more independent to switch to a middleware in case YouTube fails.
Note: Also removed the checkstyle suppression file in favor of
// CHECKSTYLE:OFFand// CHECKSTYLE:ONcommentsTODO: