Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize svg assets #9801

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from
Open

Optimize svg assets #9801

wants to merge 14 commits into from

Conversation

RiedleroD
Copy link

I wanted to finish optimizing all of them before opening the PR but I think that's not happening anymore. As far as I can see, none of those SVGs are actually directly used inside the app. Otherwise, this would probably be a significant performance improvement. So this PR really only saves about 60KiB when downloading the repo and not much else. Maybe next time someone wants to change some of those icons it'll be easier because they're less messy. idk.

I'll probably optimize some of the worse xml files that actually get used some other time and open another PR.

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • optimized svg files in various ways

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@SameenAhnaf SameenAhnaf added the meta Related to the project but not strictly to code label Feb 12, 2023
@Profpatsch
Copy link
Contributor

The github preview shows that all optimized svgs now have a size of 0x0px, e.g.:

image

I feel like this might lead to problems if some code implicitly depends on these default height/widths?

@RiedleroD
Copy link
Author

huh, will look into it in a month or so. Currently absolutely swamped with work from my thesis, diploma project & finals 😓

@opusforlife2
Copy link
Collaborator

Currently absolutely swamped with work from my thesis, diploma project & finals

Good luck with those! Ace them all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Related to the project but not strictly to code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants