fix build warning of using c++ when build multirom.cpp #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with TW_USE_TOOLBOX := true in BoardConfig.mk Signed-off-by: sndnvaps <sndnvaps@gmail.com>
test MS_RELATIME if we has define in android source move MR_UPDATE_SCRIPT_PATH && MR_UPDATE_SCRIPT_NAME from multirom.cpp to multirom.h fix build warning of twrp-functions.cpp Signed-off-by: sndnvaps <sndnvaps@gmail.com>
sndnvaps
changed the title
| @@ -177,8 +182,8 @@ bool MultiROM::setRomsPath(std::string loc) | |||
| return false; | |||
| } | |||
|
|
|||
| m_curr_roms_path = "/mnt/multirom-"TARGET_DEVICE"/"; | |||
| mkdir("/mnt/multirom-"TARGET_DEVICE"/", 0777); | |||
| m_curr_roms_path = "/mnt/multirom-" + (string)TARGET_DEVICE + "/"; | |||
There was a problem hiding this comment.
Don't cast it to string, just put a space in between the quotatuion marks and TARGET_DEVICE define.
Fix build warning when using c++ compiler Signed-off-by: sndnvaps <sndnvaps@gmail.com>
|
@Tasssadar i have fix the problem you just promote. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix build warning of using c++ when build multirom.cpp