[Fix] Accessibility element's bounding rect will get wrong if the con… #803
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repro steps:
Using AddLinkToURL: to add two urls inside the text, such as ‘Affogato’ and ‘mylink’.Note that the text must contain ‘\n’ character to repro this bug.
label.text = @"Affogato: Espresso served over gelato. Traditionally vanilla is used, but some coffeehouses or customers use any flavor \n \n 123 mylink.";
If the label’s layout was not set correctly before adding the link, the last accessibility element will get the wrong boundingRect (all zero) from the return value of boundingREctForCharacterRange:
boundingREctForCharacterRange: using label’s bounding size to measure the position of the highlighted element but the textContainer seems to ignore the ‘\n’ character will have additional line.
Thus, if user setting the correct frame such as using sizeToFit, it works fine. But if the user calls it later after adding the link, the position of accessibilityElement will get wrong.
Solution:
NSTextContainer’s size does not need to be the same as the label’s bounding size.
Instead, we can use
CGSizeMake(self.bounds.size.width, CGFLOAT_MAX)