Attributed Truncation Token as URL Link UI fix #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 14, 2016 10:47
…ncation token. The offset was previously calculated by taking the last line, and saying that the range of the link (and attribution token) basically started at (line length) - (attribution token length). This only works for monospaced fonts. My implementation looks at the first run of the truncated line, and uses its length as the starting position for the truncation token.
Current coverage is 76.48%@@ master #697 diff @@
==========================================
Files 2 2
Lines 944 944
Methods 112 138 +26
Messages 0 0
Branches 225 132 -93
==========================================
+ Hits 663 722 +59
Misses 128 128
+ Partials 153 94 -59
|
|
Could you add test coverage for this fix? Thanks! |
|
UI is fine, but touch doesn't work coz |
|
click lose efficacy |
|
It's still wrong if text like this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly calculating the link range when added in the attributed truncation token.
The offset was previously calculated by taking the last line, and saying that the range of the link (and attribution token) basically started at (line length) - (attribution token length). This only works for monospaced fonts. My implementation looks at the first run of the truncated line, and uses its length as the starting position for the truncation token.
Here is a visual representation of the bug:
Before
After