Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove warning + update xcodeproj to recommended settings #631

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

AndrewSB
Copy link

I've removed an if check that was seeing if there was a pointer to NSLinkAttributeName. This will always succeed (in this project) because the deployment target is ios 8.0, and NSLinkAttributeName is marked available since ios 7.

This may have failed previously, but through using a framework it will not, so I think it's safe to remove -- it's also a warning while building the framework.

I also went ahead and update the xcodeproj in Carthage/ to Apple's recommended settings

@codecov-io
Copy link

Current coverage is 89.14%

Merging #631 into master will not affect coverage as of 4bc7415

@@            master    #631   diff @@
======================================
  Files            2       2       
  Stmts         1087    1087       
  Branches         0       0       
  Methods                          
======================================
  Hit            969     969       
  Partial          0       0       
  Missed         118     118       

Review entire Coverage Diff as of 4bc7415

Powered by Codecov. Updated on successful CI builds.

@segiddins
Copy link
Member

@AndrewSB if you rebase this, the tests should pass. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants