Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSBaseLineOffsetAttributeName support #604

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

xmas79
Copy link

@xmas79 xmas79 commented Nov 3, 2015

NSBaseLineOffsetAttributeName attribute support. Please review the code.

Thanks,
xmas79.

xmas79 and others added 2 commits November 3, 2015 07:36
Added the support for NSBaseLineOffsetAttributeName in the attributed
string. Please review the code.

Thanks,
xmas79.
@codecov-io
Copy link

codecov-io commented Nov 3, 2015

Current coverage is 100%

Merging #604 into master will decrease coverage by +29.77%

  1. File ...TTTAttributedLabel.h (not in diff) was modified. more
    • Misses 0
    • Partials 0
    • Hits +2
@@             master    #604   diff @@
=======================================
  Files             2       1     -1   
  Lines           944      31   -913   
  Methods         112       0   -112   
  Branches        225       0   -225   
=======================================
- Hits            663      31   -632   
+ Misses          128       0   -128   
+ Partials        153       0   -153   

Powered by Codecov. Last updated by fe0d562...e2b5ff1

@getaaron
Copy link
Contributor

Thanks for the PR, @xmas79. Can you please add some automated tests to cover this change and I'll merge it in?

@xmas79
Copy link
Author

xmas79 commented Dec 14, 2015

Hello,
the ci/circleci tests failed because of:

Xcode version '6.3.1' is not available. Available versions are: 6.4, 7.0, 7.1
Action failed: Configure the build

I don't know how to proceed.

Thanks,
xmas79.

@mostinho7
Copy link

Thanks for the pull request @xmas79 I am using this in a project and it's causing me problems as well. I hope it gets merged in asap.
Thanks for TTTAttributedLabel @getaaron

@segiddins
Copy link
Member

Circle has been fixed, but this still needs test coverage & a rebase to be mergable

@jessesquires jessesquires added this to the 2.1.0 milestone May 10, 2016
@rickharrison
Copy link
Member

Unless I am doing something incorrectly, it does not appear that this will offset any text above it. I.E. it will render on top of other lines of text if the offset is large enough.

@wildseansy
Copy link

wildseansy commented Jul 22, 2016

@rickharrison - For my use case this is better than no support at all for NSBaselineOffsetAttributeName.

For the most part, I just want to adjust different font types slightly with respect to one another. For example an icon font placed next to some text, it's nice to vertically adjust the icon. Lines bleeding into one another could be a subsequent improvement, if there is a need.

idcuesta added a commit to SolarCS/TTTAttributedLabel that referenced this pull request Jan 20, 2020
idcuesta added a commit to SolarCS/TTTAttributedLabel that referenced this pull request Jan 20, 2020
idcuesta added a commit to SolarCS/TTTAttributedLabel that referenced this pull request Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants