New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NSBaseLineOffsetAttributeName support #604
base: master
Are you sure you want to change the base?
Conversation
Added the support for NSBaseLineOffsetAttributeName in the attributed string. Please review the code. Thanks, xmas79.
NSBaseLineOffsetAttributeName support
Current coverage is 100%
@@ master #604 diff @@
=======================================
Files 2 1 -1
Lines 944 31 -913
Methods 112 0 -112
Branches 225 0 -225
=======================================
- Hits 663 31 -632
+ Misses 128 0 -128
+ Partials 153 0 -153
|
Thanks for the PR, @xmas79. Can you please add some automated tests to cover this change and I'll merge it in? |
Hello, Xcode version '6.3.1' is not available. Available versions are: 6.4, 7.0, 7.1 I don't know how to proceed. Thanks, |
Circle has been fixed, but this still needs test coverage & a rebase to be mergable |
Unless I am doing something incorrectly, it does not appear that this will offset any text above it. I.E. it will render on top of other lines of text if the offset is large enough. |
@rickharrison - For my use case this is better than no support at all for For the most part, I just want to adjust different font types slightly with respect to one another. For example an icon font placed next to some text, it's nice to vertically adjust the icon. Lines bleeding into one another could be a subsequent improvement, if there is a need. |
NSBaseLineOffsetAttributeName attribute support. Please review the code.
Thanks,
xmas79.