feat: save 2 css snippets #459
Open
+23
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleyboar
changed the title
wesleyboar
commented
May 13, 2024
Comment on lines
+8
to
+12
| /* | ||
| .nav-link:focus-visible, | ||
| #header-logo:focus-visible, | ||
| .navbar-dark .navbar-toggler:focus-visible { | ||
| */ |
There was a problem hiding this comment.
I do not know why this is commented out. When I remember, or when prodded, I will comment it or remove it accordingly.
| @@ -23,7 +26,7 @@ | |||
| left: 0; top: 0; bottom: 0; right: 0; | |||
| background-color: var(--global-color-primary--x-light); | |||
| } | |||
| .banner-cell--major a:hover .u-highlight { | |||
| .banner-cell--major a:hover :is(.u-highlight, .highlight) { | |||
There was a problem hiding this comment.
Two class names are supported: ITCSS class name, simple class name.
Comment on lines
+1
to
+3
| <template id="css-banner-tacc--notes"> | ||
| <!-- TO DYNAMICALL REDUCE HEIGHT OF BANNER: NO NEED to edit this stylesheet. Edit banner "Picture / Image" on CMS. Set `style="height: 60vh; max-height: 550px; min-height: 230px;"`. To use static height, set `style="height: 550px"` instead. --> | ||
| </template> |
There was a problem hiding this comment.
If dev is asked to change height of the banner, and sees this snippet, they may be tempted to work in here. But this stylesheet intentionally does not manage the banner height.¹
- Why? Core-CMS code clones
styleattribute given to a CMS image to appear on an<a>or<figure>tag that wraps the<image>. This hack² fixes a bug³ that Django CMS does not account for when it provides the feature that adds the wrapper. An<a>is added when the Picture / Image has Link settings. A<figure>is added when the Picture / Image is given a Caption. - Introspection on the "hack" by @wesleyboar has led him to realize that Django CMS templates intentionally do not consider every case; they are samples that he has been treating as finished products. Their "bugs"³ may be his failure to replace the templates with ones that work as he demands.
- The bug is that the styles intended for the image box apply to the image without a wrapper and with a wrapper, which results in different rendering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Save snippet that only existed in CMS content. Migrate a note to an existing snippet.
Related
None.
Changes
templates/css-global-a11y.htmltemplates/css-banner-tacc.htmlTesting
Note
Not required. This change merely saves code that has been working live.
UI