Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CMD-112 overwrite confirmation e-mail #448

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Mar 27, 2024

Overview

  • Use Core-CMS confirmation e-mail code.
  • Overwrite Core-CMS confirmation e-mail content.

Status

Related

Changes

  • added confirmation email overwrite files
  • removed TUP's confirmation e-mail code

Testing

  1. npx nx build tup-cms
    npx nx serve tup-cms
  2. Open a CMS form (not /about/help) with an e-mail field (display name is "Email" or "email").
  3. Make sure form would send e-mail e.g.
    • edit form and have e-mail address in "Send form data to e-mail address:",
    • in /apps/tup-cms/src/taccsite_cms/settings_local.py, set DEFAULT_FROM_EMAIL to an e-mail address.
  4. Submit e-mail address via form.
  5. Verify only one confirmation e-mail (text and html versions) would be received.
  6. Verify that confirmation e-mail has "Business hours …" paragraph.

UI

Docker log (send to user)

tup_cms | [DJANGO] DEBUG 2024-04-01 16:06:38,314 UTC apps portal.common_apps.email_management.apps.callback:40: received submission from Help (Not Via RT)
tup_cms | [DJANGO] DEBUG 2024-04-01 16:06:38,314 UTC apps portal.common_apps.email_management.apps.callback:41: <class 'dict'>
tup_cms | [DJANGO] DEBUG 2024-04-01 16:06:38,316 UTC apps portal.apps.portal.apps.callback:46: received submission from Help (Not Via RT)
tup_cms | Content-Type: multipart/alternative;
tup_cms | boundary="===============3785253249513235131=="
tup_cms | MIME-Version: 1.0
tup_cms | Subject: TACC Form Submission Received: Help (Not Via RT)
tup_cms | From: no-reply@tacc.utexas.edu
tup_cms | To: one@more.time
tup_cms | Date: Mon, 01 Apr 2024 21:06:38 -0000
tup_cms | Message-ID: <171200559831.9.11548662848347038720@tup_cms>
tup_cms |
tup_cms | --===============3785253249513235131==
tup_cms | Content-Type: text/plain; charset="utf-8"
tup_cms | MIME-Version: 1.0
tup_cms | Content-Transfer-Encoding: 7bit
tup_cms |
tup_cms |
tup_cms | Greetings,
tup_cms |
tup_cms | You have successfully submitted a form on the TUP CMS website. Thank you for your submission.
tup_cms |
tup_cms | Business hours are Monday - Friday, 8AM to 5PM Central. We will respond to your submission according to the information provided on the form webpage.
tup_cms |
tup_cms | Sincerely,
tup_cms | TUP CMS Communications
tup_cms |
tup_cms | --===============3785253249513235131==
tup_cms | Content-Type: text/html; charset="utf-8"
tup_cms | MIME-Version: 1.0
tup_cms | Content-Transfer-Encoding: 7bit
tup_cms |
tup_cms |
tup_cms |

Greetings,


tup_cms |


tup_cms | You have successfully submitted a form on the TUP CMS website. Thank you for your submission.
tup_cms |


tup_cms |


tup_cms | Business hours are Monday - Friday, 8AM to 5PM Central. We will respond to your submission according to the information provided on the form webpage.
tup_cms |


tup_cms |


tup_cms | Sincerely,

tup_cms | TUP CMS Communications
tup_cms |


tup_cms |
tup_cms | --===============3785253249513235131==--
tup_cms |
tup_cms | -------------------------------------------------------------------------------

Docker log (send to TACC)
tup_cms           | [DJANGO] INFO 2024-04-01 16:06:31,292 UTC basehttp django.server.log_message:212: "GET /core/markup/nav/ HTTP/1.1" 200 1218
tup_cms           | Content-Type: multipart/alternative;
tup_cms           |  boundary="===============1556261318995665495=="
tup_cms           | MIME-Version: 1.0
tup_cms           | Subject: Form Submission - Help (Not Via RT)
tup_cms           | From: webmaster@localhost
tup_cms           | To: wbomar@tacc.utexas.edu
tup_cms           | Date: Mon, 01 Apr 2024 21:06:38 -0000
tup_cms           | Message-ID: <171200559831.9.680013331273973475@tup_cms>
tup_cms           | 
tup_cms           | --===============1556261318995665495==
tup_cms           | Content-Type: text/plain; charset="utf-8"
tup_cms           | MIME-Version: 1.0
tup_cms           | Content-Transfer-Encoding: 7bit
tup_cms           | 
tup_cms           | 
tup_cms           | 
tup_cms           | Form: Help (Not Via RT)
tup_cms           | Date: 1st April 2024 16:06
tup_cms           | 
tup_cms           | 
tup_cms           | Name:
tup_cms           | Once More
tup_cms           | 
tup_cms           | Email:
tup_cms           | one@more.time
tup_cms           | 
tup_cms           | 
tup_cms           | Sent via http://localhost:8000
tup_cms           | 
tup_cms           | --===============1556261318995665495==
tup_cms           | Content-Type: text/html; charset="utf-8"
tup_cms           | MIME-Version: 1.0
tup_cms           | Content-Transfer-Encoding: 7bit
tup_cms           | 
tup_cms           | <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
tup_cms           | <html xmlns="http://www.w3.org/1999/xhtml">
tup_cms           |     <head>
tup_cms           |         <meta name="viewport" content="width=device-width" />
tup_cms           |         <meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
tup_cms           |         <title>Form Submission - Help (Not Via RT)</title>
tup_cms           |     </head>
tup_cms           |     <body itemscope itemtype="http://schema.org/EmailMessage">
tup_cms           |         <h1></h1>
tup_cms           |         <p><strong>Date:</strong> 1st April 2024 16:06</p>
tup_cms           |         
tup_cms           |             <p>
tup_cms           |                 <strong>Name:</strong><br/>
tup_cms           |                 Once More
tup_cms           |             </p>
tup_cms           |         
tup_cms           |             <p>
tup_cms           |                 <strong>Email:</strong><br/>
tup_cms           |                 one@more.time
tup_cms           |             </p>
tup_cms           |         
tup_cms           |         Sent via <a href="http://localhost:8000/about/help-not-via-rt/">localhost:8000/about/help-not-via-rt/</a>
tup_cms           |     </body>
tup_cms           | </html>
tup_cms           | 
tup_cms           | --===============1556261318995665495==--
tup_cms           | 
tup_cms           | -------------------------------------------------------------------------------

@wesleyboar wesleyboar marked this pull request as ready for review March 28, 2024 00:15
@wesleyboar wesleyboar marked this pull request as draft March 28, 2024 21:34
@wesleyboar
Copy link
Member Author

@wesleyboar wesleyboar marked this pull request as ready for review April 1, 2024 20:24
Copy link
Member Author

@wesleyboar wesleyboar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tweaks

apps/tup-cms/src/taccsite_cms/settings_custom.py Outdated Show resolved Hide resolved
apps/tup-cms/src/taccsite_cms/settings_custom.py Outdated Show resolved Hide resolved
@wesleyboar wesleyboar requested a review from jarosenb April 1, 2024 21:08
@wesleyboar wesleyboar changed the title test: CMD-112 overwrite confirmation e-mail feat: CMD-112 overwrite confirmation e-mail Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant