Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: core-cms v4.8 & core-styles v2.25 #436

Merged
merged 8 commits into from
Mar 6, 2024
Merged

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Mar 1, 2024

Overview

Update Core-CMS & Core-Styles to latest versions.

Related

Changes

Core-CMS

Core-Styles

Testing

Core-CMS

  1. Create/View news filtered by tag e.g. https://tacc.utexas.edu/news/latest-news/tag/frontera/. Verify it looks like "NEWS — Frontera" (where "Frontera" is the tag name)
    i.e. TUP-707

  2. View/Add link to external site that does not have target="_blank" set. Reload page. Verify link markup is given both target="_blank" and aria-description="Opens in new window".
    i.e. TUP-702

  3. Test on TUP. Load homepage. Verify all home page banner links do not open in a new window.
    i.e. TUP-707

Core-Styles on CMS

  1. View/Add a table. View on narrow screen. Verify it still looks CMS table.
    i.e. does not have TUP-534 yet

    Sample Markup
    <table>
      <thead>
        <tr>
          <th>Sample</th>
          <th>Table</th>
        </tr>
      </thead>
      <tbody>
        <tr>
          <td>and</td>
          <td>some</td>
        </tr>
        <tr>
          <td>sample</td>
          <td>data</td>
        </tr>
      </tbody>
    </table>
  2. View/Add a button pattern with less text and wide width. Verify text is centered.
    i.e. TACC/Core-Styles#307

    Sample Markup
    <button class="c-button c-button--type-primary c-button--width-long">Button</button>
  3. View/Add a tag pattern. Verify it has padding of 0.25rem 0.5rem 0rem (source).
    TACC/Core-Styles#301

    Sample Markup
    <span class="c-tag c-tag--feature">Tag</span>
  4. View/Add an <hr>. Verify it does not have width: 100%.
    i.e. TACC/Core-Styles#310

    Sample Markup
    <hr />
  5. Cause a CMS form error — one way is to fill out form, throttle network to appear offline, and submit form. Verify form error has correct padding.
    i.e. Check that TUP-676 is fixed.

Core-Styles on Portal

  1. Visit http://localhost:8000/portal/account. Verify text of purple buttons is centered.
    i.e. TACC/Core-Styles#307

UI

Core-CMS

  1. news tagged frontera
    tag - frontera
  2. docs.tacc opens in new window
    open in new window
  3. homepage small image links homepage big image link
    small links to localhost big link to locahost

Core-Styles on CMS

1. table 2. button
table button
3. tag 4. hr
tag hr
  1. before after
    TUP-661 cms form error

Core-Styles on Portal

  1. before after
    before after

@wesleyboar wesleyboar marked this pull request as ready for review March 4, 2024 18:57
@wesleyboar wesleyboar changed the title feat: core-cms v4.8 & core-styles v2.25 feat: core-cms v4.8 & core-styles v2.25 ⚠️ Mar 4, 2024
@wesleyboar wesleyboar requested a review from jarosenb March 5, 2024 00:59
@wesleyboar wesleyboar changed the title feat: core-cms v4.8 & core-styles v2.25 ⚠️ feat: core-cms v4.8 & core-styles v2.25 Mar 5, 2024
Comment on lines -13 to +14
{% with settings.FAVICON as favicon %}
<link rel="icon" href="{% static favicon.img_file_src %}" type="image/x-icon" />
{% with settings.PORTAL_FAVICON as favicon %}
<link rel="icon" href="{% if favicon.is_remote %}{{ favicon.img_file_src }}{% else %}{% static favicon.img_file_src %}{% endif %}" type="image/x-icon" />
Copy link
Member Author

@wesleyboar wesleyboar Mar 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wesleyboar wesleyboar merged commit 68d6a27 into main Mar 6, 2024
1 check passed
@wesleyboar wesleyboar deleted the feat/core-cms-v4-8-2 branch March 6, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants