Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: TUP-667 add instagram to social media #397

Closed
wants to merge 4 commits into from

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Dec 15, 2023

Overview

  • Add "Instagram" to social media platforms.
  • Add social media platforms setting in repo.1

Related

Changes

  • added TACC_SOCIAL_SHARE_PLATFORMS to settings
  • changed order of social media platforms (compared to what was on dev)

Testing

Note

Not available to test on https://dev.tup.tacc.utexas.edu/ until TACC_SOCIAL_SHARE_PLATFORMS setting is removed from server.

  1. Open a news article.
  2. See:
    1. LinkedIn
    2. Instagram
    3. Facebook
    4. Email
  3. Verify clicking Instagram icon opens up option for user to share on Instagram.

UI

N/m. PR closed. Task cancelled.

Footnotes

  1. These have been on server directly, to fix emergency bug.

@wesleyboar wesleyboar changed the title feat: add isnstagram to social media feat: add instagram to social media Dec 15, 2023
@wesleyboar wesleyboar marked this pull request as ready for review December 15, 2023 23:30
@wesleyboar wesleyboar marked this pull request as draft December 18, 2023 18:17
@wesleyboar wesleyboar changed the title feat: add instagram to social media feat: TUP-667 add instagram to social media Dec 18, 2023
# TACC: SOCIAL MEDIA
########################

TACC_SOCIAL_SHARE_PLATFORMS = ['linkedin', 'instagram', 'facebook', 'email']
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

After #416, this must become PORTAL_SOCIAL_SHARE_PLATFORMS.

@wesleyboar
Copy link
Member Author

A “share on instagram" link is not a thing. PR clsoed. Task closed.

@wesleyboar wesleyboar closed this Mar 8, 2024
@wesleyboar wesleyboar deleted the feat/add-instagram-to-social-media branch March 8, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant