New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/form patterns bugs found via tup UI #91
base: main
Are you sure you want to change the base?
Commits on Nov 21, 2022
-
feat(base): (root), cms, portal, header, updates
Also: - add MuiTab use case to bootstrap.modal - add MuiTab stylesheet for portal - remove outdated icon trump files - add base stylesheets for clients to load Client should always load base.css first. | stylesheet | root¹ | cms² | portal³ | header ⁴ | | - | - | - | - | - | | base.css | ✓ | — | — | — | | base.cms.css | — | ✓ | — | — | | base.portal.css | — | — | ✓ | — | | base.header.css | — | — | — | ✓ | There may be a base.docs.css after TUP-264. ¹ everything except cms, portal, and header ² e.g. cms ³ e.g. cepv2, tup-ui ⁴ e.g. cms, cepv2, frontera-tech-docs
Configuration menu - View commit details
-
Copy full SHA for f695ad1 - Browse repository at this point
Copy the full SHA f695ad1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1997b8a - Browse repository at this point
Copy the full SHA 1997b8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 17e459c - Browse repository at this point
Copy the full SHA 17e459cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d02c0d0 - Browse repository at this point
Copy the full SHA d02c0d0View commit details
Commits on Nov 22, 2022
-
fix: rename base.*.css to core-styles.*.css
| stylesheet | root¹ | cms² | portal³ | header ⁴ | | - | - | - | - | - | | core-styles.base.css | ✓ | — | — | — | | core-styles.cms.css | — | ✓ | — | — | | core-styles.portal.css | — | — | ✓ | — | | core-styles.header.css | — | — | — | ✓ | There may be a core-styles.docs.css after TUP-264. ¹ everything except cms, portal, and header ² e.g. cms ³ e.g. cepv2, tup-ui ⁴ e.g. cms, cepv2, frontera-tech-docs
Configuration menu - View commit details
-
Copy full SHA for 8bb41c3 - Browse repository at this point
Copy the full SHA 8bb41c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2ff5a4 - Browse repository at this point
Copy the full SHA f2ff5a4View commit details -
fix(core-styles): header trump cms when layered
With layers, core-styles.header.css must overwrite core-styles.cms.css. Sans layers, site.header.css relied on bootstrap to override site.css.
Configuration menu - View commit details
-
Copy full SHA for 0ee442a - Browse repository at this point
Copy the full SHA 0ee442aView commit details -
Configuration menu - View commit details
-
Copy full SHA for dc108df - Browse repository at this point
Copy the full SHA dc108dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 44dee14 - Browse repository at this point
Copy the full SHA 44dee14View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17a5c25 - Browse repository at this point
Copy the full SHA 17a5c25View commit details -
Configuration menu - View commit details
-
Copy full SHA for 015bca7 - Browse repository at this point
Copy the full SHA 015bca7View commit details -
fix(core-styles): avoid duplicate custom prop defs
Avoid dupllicate custom property (a.k.a. variable) definitions in: - `.core-styles.cms.css` - `.core-styles.header.css`
Configuration menu - View commit details
-
Copy full SHA for 3a0cce0 - Browse repository at this point
Copy the full SHA 3a0cce0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 566ee9d - Browse repository at this point
Copy the full SHA 566ee9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for abc5e9f - Browse repository at this point
Copy the full SHA abc5e9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 29c5f63 - Browse repository at this point
Copy the full SHA 29c5f63View commit details
Commits on Nov 23, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 1a8df00 - Browse repository at this point
Copy the full SHA 1a8df00View commit details -
wip(form): elements, components, relevant changes
- some changes may be for main branch - some changes may be for task/base-cms-portal-header branch 1. testing pattern for Core-CMS djangco.cms.forms 2. new c-form component & pattern needs template 3. just begining form.cms pattern 4. update s-affixed-input-… accordingly (for: 2, 3) 4. initial change of partials to use core-styles.*.css
Configuration menu - View commit details
-
Copy full SHA for 1cbc279 - Browse repository at this point
Copy the full SHA 1cbc279View commit details -
Configuration menu - View commit details
-
Copy full SHA for c56ad2d - Browse repository at this point
Copy the full SHA c56ad2dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 849e9c9 - Browse repository at this point
Copy the full SHA 849e9c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 97807e7 - Browse repository at this point
Copy the full SHA 97807e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for c471d84 - Browse repository at this point
Copy the full SHA c471d84View commit details -
wip(form): elements, components, relevant changes
- some changes may be for main branch - some changes may be for task/base-cms-portal-header branch 1. testing pattern for Core-CMS djangco.cms.forms 2. new c-form component & pattern needs template 3. just begining form.cms pattern 4. update s-affixed-input-… accordingly (for: 2, 3) 4. initial change of partials to use core-styles.*.css
Configuration menu - View commit details
-
Copy full SHA for c607adc - Browse repository at this point
Copy the full SHA c607adcView commit details -
Configuration menu - View commit details
-
Copy full SHA for b34166d - Browse repository at this point
Copy the full SHA b34166dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3097b77 - Browse repository at this point
Copy the full SHA 3097b77View commit details -
Configuration menu - View commit details
-
Copy full SHA for 01932d3 - Browse repository at this point
Copy the full SHA 01932d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 89d77a6 - Browse repository at this point
Copy the full SHA 89d77a6View commit details -
fix(components): django-cms-forms pattern (cms)
This is for CMS, but was being tested here. it works now. Latest real bug was misssing the .html extension inthe demo. This pattern was just committed in TACC/Core-CMS: - task/get-core-styles-beyond-0.11.0 - d13ca50 I am porting the polishes and fixes here just so that when I delete I am deleting at the time at which CMS resumes control of it.
Configuration menu - View commit details
-
Copy full SHA for b336a48 - Browse repository at this point
Copy the full SHA b336a48View commit details -
Configuration menu - View commit details
-
Copy full SHA for 243aceb - Browse repository at this point
Copy the full SHA 243acebView commit details -
fix!: avoid redundant custom property definitions
- build - removed import of settings by src/_imports files - added `core-styles.settings.css` - changed demo to always load `core-styles.settings.css` up front BREAKING CHANGE: Clients must include `settings.css` OR `base.css` e.g. - @import url('@tacc/core-styles/dist/core-styles.settings.css') - @import url('@tacc/core-styles/dist/core-styles.base.css')
Configuration menu - View commit details
-
Copy full SHA for ca1b35d - Browse repository at this point
Copy the full SHA ca1b35dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ca3f568 - Browse repository at this point
Copy the full SHA ca3f568View commit details -
fix(demo): load core-styles.base via config
Loading manually meant clients were forced to build off of it. But clients may include core-styles.base along with other files and want to configure that to load. Without this change, and with a client doing that, the client receives duplicate (hard to track down) css.
Configuration menu - View commit details
-
Copy full SHA for 436995b - Browse repository at this point
Copy the full SHA 436995bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c60d40c - Browse repository at this point
Copy the full SHA c60d40cView commit details
Commits on Nov 27, 2022
-
fix(demo): core-styles.base from absolute path
This allowed npx serve and npm start to both load the file.
Configuration menu - View commit details
-
Copy full SHA for 5e2fd8f - Browse repository at this point
Copy the full SHA 5e2fd8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e52133 - Browse repository at this point
Copy the full SHA 6e52133View commit details -
Configuration menu - View commit details
-
Copy full SHA for bfe93de - Browse repository at this point
Copy the full SHA bfe93deView commit details -
Configuration menu - View commit details
-
Copy full SHA for db8fec4 - Browse repository at this point
Copy the full SHA db8fec4View commit details -
fix(fonts)!: support font load on demo
All clients must change font path replacement assumption: - before, dist had ../fonts - after, dist has ./fonts
Configuration menu - View commit details
-
Copy full SHA for e653718 - Browse repository at this point
Copy the full SHA e653718View commit details
Commits on Nov 28, 2022
-
Configuration menu - View commit details
-
Copy full SHA for d51af9e - Browse repository at this point
Copy the full SHA d51af9eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e3d54f - Browse repository at this point
Copy the full SHA 9e3d54fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e8a600d - Browse repository at this point
Copy the full SHA e8a600dView commit details -
wip(form): c-form & html-elements
- build dist - changed c-form.hbs to use c-form markup - changed django-cms-forms to not load bootstrap - changed django-cms-forms to load component - removed extra stuff from django-cms-forms.hbs - fixed selector `:not` syntax in c-forms.css - fixed message font-weight in django-cms-form-hacks.css - removed outdated docs comment from django-cms-forms.css - fixed URL copy-pasta in elements/form.cms - added html-elements.css (for base) - changed ….base.css to load html-elements.css
Configuration menu - View commit details
-
Copy full SHA for 0b3e4e0 - Browse repository at this point
Copy the full SHA 0b3e4e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8eb54d2 - Browse repository at this point
Copy the full SHA 8eb54d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2f4fd2 - Browse repository at this point
Copy the full SHA c2f4fd2View commit details -
Configuration menu - View commit details
-
Copy full SHA for e551b95 - Browse repository at this point
Copy the full SHA e551b95View commit details -
Configuration menu - View commit details
-
Copy full SHA for f430104 - Browse repository at this point
Copy the full SHA f430104View commit details -
Configuration menu - View commit details
-
Copy full SHA for f156361 - Browse repository at this point
Copy the full SHA f156361View commit details -
Configuration menu - View commit details
-
Copy full SHA for d664919 - Browse repository at this point
Copy the full SHA d664919View commit details -
Configuration menu - View commit details
-
Copy full SHA for 067540c - Browse repository at this point
Copy the full SHA 067540cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f7f08e - Browse repository at this point
Copy the full SHA 9f7f08eView commit details -
feat(demo): pattern script assets must be modules
Without this, modules jsut don't work. Better to use modules than not.
Configuration menu - View commit details
-
Copy full SHA for 4a483ef - Browse repository at this point
Copy the full SHA 4a483efView commit details -
feat(components): forms, toggle required & errors
Allow form aptterns to have buttons that - toggle whether form errors are shown - toggle whether fields are required Add sample form errors.
Configuration menu - View commit details
-
Copy full SHA for 7243312 - Browse repository at this point
Copy the full SHA 7243312View commit details -
fix(components): forms, select errors by query
Select error lists by query, not class. So we can get `.field-errors` and `.form-errors`.
Configuration menu - View commit details
-
Copy full SHA for 956f927 - Browse repository at this point
Copy the full SHA 956f927View commit details
Commits on Nov 29, 2022
-
feat: c-message scopes & complete a11y colors
Notice: The c-message is not documented yet.
Configuration menu - View commit details
-
Copy full SHA for 49a26a8 - Browse repository at this point
Copy the full SHA 49a26a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for a5142a0 - Browse repository at this point
Copy the full SHA a5142a0View commit details -
feat(demo)!: refactor asset load
- removed excess _preview's and their _partial's - changed configuration API (see BREAKING CHANGE) - removed duplicate demo css - changed config's to use new API instead of partials - removed excess supportStyles - changed demo styles location - added core-styles.demo.css - fixed s-cms-nav margin - added c-message to core-styles.base.css BREAKING CHANGE: Configuration: - + shouldLoadBootstrap - + shouldSkipBootstrap - + shouldLoadCMS - + shouldSkipCMS - shouldSkipBase → shouldSkipPattern - styles.internal.global → globalStyles {isInternal, layer, path} - styles.external.global → globalStyles {isInternal, layer, path}
Configuration menu - View commit details
-
Copy full SHA for 273c0f5 - Browse repository at this point
Copy the full SHA 273c0f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 70049dd - Browse repository at this point
Copy the full SHA 70049ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a10619 - Browse repository at this point
Copy the full SHA 8a10619View commit details -
Merge branch 'dev--task/form-patterns' into dev--task/form-patterns--…
…task/base-cms-portal-header
Configuration menu - View commit details
-
Copy full SHA for d1f9a89 - Browse repository at this point
Copy the full SHA d1f9a89View commit details -
fix(s-portal-nav): undo s-portal-nav margin bottom
Mimix same fix for s-cms-nav in 273c0f5 ("feat(demo)!: refactor asset load").
Configuration menu - View commit details
-
Copy full SHA for 843f548 - Browse repository at this point
Copy the full SHA 843f548View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f3e0c6 - Browse repository at this point
Copy the full SHA 6f3e0c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c8c2e8 - Browse repository at this point
Copy the full SHA 2c8c2e8View commit details
Commits on Nov 30, 2022
-
Configuration menu - View commit details
-
Copy full SHA for b24663a - Browse repository at this point
Copy the full SHA b24663aView commit details -
Merge branch 'dev--task/form-patterns' into dev--task/form-patterns--…
…task/base-cms-portal-header
Configuration menu - View commit details
-
Copy full SHA for 48d2c36 - Browse repository at this point
Copy the full SHA 48d2c36View commit details -
fix: restore and re-use core-styles.settnings.css
TACC/tup-ui:/apps/ui-patterns needs this.
Configuration menu - View commit details
-
Copy full SHA for 71e43a5 - Browse repository at this point
Copy the full SHA 71e43a5View commit details -
wip(forms): fixes for tup-ui use cases
⚠️ Untested: - label font weight medium not bold - errors to not require <ul>Configuration menu - View commit details
-
Copy full SHA for 1a80160 - Browse repository at this point
Copy the full SHA 1a80160View commit details -
fix(core-styles): internal layers
And update s-affixed-input-wrapper markup to avoid style conflict.
Configuration menu - View commit details
-
Copy full SHA for c99c880 - Browse repository at this point
Copy the full SHA c99c880View commit details -
Merge branch 'dev--task/form-patterns--task/base-cms-portal-header' i…
…nto dev--task/form-patterns--task/base-cms-portal-header--bugfix/form-patterns-bugs-found-via-tup-ui
Configuration menu - View commit details
-
Copy full SHA for 9256831 - Browse repository at this point
Copy the full SHA 9256831View commit details -
Configuration menu - View commit details
-
Copy full SHA for d11049f - Browse repository at this point
Copy the full SHA d11049fView commit details -
fix(core-styles): internal layers
And update s-affixed-input-wrapper markup to avoid style conflict.
Configuration menu - View commit details
-
Copy full SHA for fb7e370 - Browse repository at this point
Copy the full SHA fb7e370View commit details -
fix(core-styles): internal layers
And update s-affixed-input-wrapper markup to avoid style conflict.
Configuration menu - View commit details
-
Copy full SHA for c04bebe - Browse repository at this point
Copy the full SHA c04bebeView commit details -
Merge branch 'dev--task/form-patterns--task/base-cms-portal-header' i…
…nto dev--task/form-patterns--task/base-cms-portal-header--bugfix/form-patterns-bugs-found-via-tup-ui
Configuration menu - View commit details
-
Copy full SHA for 18d0b85 - Browse repository at this point
Copy the full SHA 18d0b85View commit details
Commits on Dec 1, 2022
-
fix(core-styles): italicize small help text
I don't remember why this style exists. Comments clear, use case not. I know they are APCD use cases. I'll re-evaluate this style later. I worry I will forever add exceptions to it if I do not re-evaluate it.
Configuration menu - View commit details
-
Copy full SHA for 1792d6d - Browse repository at this point
Copy the full SHA 1792d6dView commit details -
docs(forms): hint, fix file input button size diff
This may fix the file input button size difference between cms and demo.
Configuration menu - View commit details
-
Copy full SHA for 17e35e3 - Browse repository at this point
Copy the full SHA 17e35e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f7545d - Browse repository at this point
Copy the full SHA 7f7545dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 14cb14e - Browse repository at this point
Copy the full SHA 14cb14eView commit details -
Merge branch 'dev--task/form-patterns' into dev--task/form-patterns--…
…task/base-cms-portal-header
Configuration menu - View commit details
-
Copy full SHA for 1caf697 - Browse repository at this point
Copy the full SHA 1caf697View commit details -
Merge branch 'dev--task/form-patterns--task/base-cms-portal-header' i…
…nto dev--task/form-patterns--task/base-cms-portal-header--bugfix/form-patterns-bugs-found-via-tup-ui
Configuration menu - View commit details
-
Copy full SHA for c0c6379 - Browse repository at this point
Copy the full SHA c0c6379View commit details
Commits on Dec 2, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 520014f - Browse repository at this point
Copy the full SHA 520014fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d1941c - Browse repository at this point
Copy the full SHA 8d1941cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 96a159c - Browse repository at this point
Copy the full SHA 96a159cView commit details -
Merge branch 'dev--task/form-patterns' into dev--task/form-patterns--…
…task/base-cms-portal-header
Configuration menu - View commit details
-
Copy full SHA for c77c1de - Browse repository at this point
Copy the full SHA c77c1deView commit details -
Merge branch 'dev--task/form-patterns--task/base-cms-portal-header' i…
…nto dev--task/form-patterns--task/base-cms-portal-header--bugfix/form-patterns-bugs-found-via-tup-ui
Configuration menu - View commit details
-
Copy full SHA for 63002fe - Browse repository at this point
Copy the full SHA 63002feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e2960f - Browse repository at this point
Copy the full SHA 4e2960fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 87483dc - Browse repository at this point
Copy the full SHA 87483dcView commit details -
Merge branch 'dev--task/form-patterns' into dev--task/form-patterns--…
…task/base-cms-portal-header
Configuration menu - View commit details
-
Copy full SHA for 3786359 - Browse repository at this point
Copy the full SHA 3786359View commit details -
Merge branch 'dev--task/form-patterns--task/base-cms-portal-header' i…
…nto dev--task/form-patterns--task/base-cms-portal-header--bugfix/form-patterns-bugs-found-via-tup-ui
Configuration menu - View commit details
-
Copy full SHA for e6ae817 - Browse repository at this point
Copy the full SHA e6ae817View commit details -
Configuration menu - View commit details
-
Copy full SHA for de99056 - Browse repository at this point
Copy the full SHA de99056View commit details -
Merge branch 'dev--task/form-patterns--task/base-cms-portal-header' i…
…nto dev--task/form-patterns--task/base-cms-portal-header--bugfix/form-patterns-bugs-found-via-tup-ui
Configuration menu - View commit details
-
Copy full SHA for e7807d1 - Browse repository at this point
Copy the full SHA e7807d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a48cb5 - Browse repository at this point
Copy the full SHA 5a48cb5View commit details -
Merge branch 'dev--task/form-patterns--task/base-cms-portal-header' i…
…nto dev--task/form-patterns--task/base-cms-portal-header--bugfix/form-patterns-bugs-found-via-tup-ui
Configuration menu - View commit details
-
Copy full SHA for 4e74bb7 - Browse repository at this point
Copy the full SHA 4e74bb7View commit details -
Configuration menu - View commit details
-
Copy full SHA for e1e5be6 - Browse repository at this point
Copy the full SHA e1e5be6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 996c069 - Browse repository at this point
Copy the full SHA 996c069View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e9c0a2 - Browse repository at this point
Copy the full SHA 5e9c0a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for cfd6ad3 - Browse repository at this point
Copy the full SHA cfd6ad3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 84b6aeb - Browse repository at this point
Copy the full SHA 84b6aebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b164e4 - Browse repository at this point
Copy the full SHA 8b164e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for dde34f1 - Browse repository at this point
Copy the full SHA dde34f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b2ff0f5 - Browse repository at this point
Copy the full SHA b2ff0f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1684413 - Browse repository at this point
Copy the full SHA 1684413View commit details -
Configuration menu - View commit details
-
Copy full SHA for b42422b - Browse repository at this point
Copy the full SHA b42422bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0870dcd - Browse repository at this point
Copy the full SHA 0870dcdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 33fa55e - Browse repository at this point
Copy the full SHA 33fa55eView commit details -
feat: postcss-preset-env from ^7.8.2 to ^7.8.3
This update fixes bug where layer() was not retained on @import rules!
Configuration menu - View commit details
-
Copy full SHA for 25e15ad - Browse repository at this point
Copy the full SHA 25e15adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 996e6f3 - Browse repository at this point
Copy the full SHA 996e6f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4856f85 - Browse repository at this point
Copy the full SHA 4856f85View commit details
Commits on Dec 5, 2022
-
fix(postcss): remove postcss-cascade-layers
This caused broken styles in CMS. The alpha solution was re-evaluated last week. It will be rolled back.
Configuration menu - View commit details
-
Copy full SHA for a772d36 - Browse repository at this point
Copy the full SHA a772d36View commit details -
Configuration menu - View commit details
-
Copy full SHA for 07c99a0 - Browse repository at this point
Copy the full SHA 07c99a0View commit details -
Merge branch 'dev--task/form-patterns--task/base-cms-portal-header' i…
…nto dev--task/form-patterns--task/base-cms-portal-header--bugfix/form-patterns-bugs-found-via-tup-ui
Configuration menu - View commit details
-
Copy full SHA for 768f07f - Browse repository at this point
Copy the full SHA 768f07fView commit details
Commits on Dec 6, 2022
-
Merge branch 'main' into dev--task/form-patterns--task/base-cms-porta…
…l-header--bugfix/form-patterns-bugs-found-via-tup-ui
Configuration menu - View commit details
-
Copy full SHA for e5f2dad - Browse repository at this point
Copy the full SHA e5f2dadView commit details
Commits on Dec 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for dea152f - Browse repository at this point
Copy the full SHA dea152fView commit details