Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: des-2725 c-app-card--types not centered #334

Merged
merged 5 commits into from
Apr 12, 2024
Merged

fix: des-2725 c-app-card--types not centered #334

merged 5 commits into from
Apr 12, 2024

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Apr 12, 2024 •
edited

Overview

A c-app-card should center its app "Types".

Related

Changes

  • changed a style in c-app-card to be easily overwritten
  • changed other styles in c-app-card to be easily overwritten

Testing

Test on https://www.designsafe-ci.org/rw/tools-applications/tools-applications-new/. See "UI".

UI

c-app-card

before after
before after

@github-actions github-actions bot added the fix Fixes user-facing behavior or feature label Apr 12, 2024
@wesleyboar wesleyboar marked this pull request as ready for review April 12, 2024 21:31
@wesleyboar wesleyboar merged commit f75e622 into main Apr 12, 2024
@wesleyboar wesleyboar deleted the fix/des-2725-app-page-styles branch April 12, 2024 21:32
@wesleyboar wesleyboar added the patch A backward-compatible fix label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix Fixes user-facing behavior or feature patch A backward-compatible fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@wesleyboar